fix code-coverage in tests specifically the test_quoting module#1650
Open
Vizonex wants to merge 6 commits intoaio-libs:masterfrom
Open
fix code-coverage in tests specifically the test_quoting module#1650Vizonex wants to merge 6 commits intoaio-libs:masterfrom
Vizonex wants to merge 6 commits intoaio-libs:masterfrom
Conversation
for more information, see https://pre-commit.ci
psf-chronographer
bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1650 +/- ##
==========================================
- Coverage 99.47% 99.46% -0.02%
==========================================
Files 30 30
Lines 5961 5955 -6
Branches 284 275 -9
==========================================
- Hits 5930 5923 -7
Misses 22 22
- Partials 9 10 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is a fix based on something I tried to help someone review rather recently #1642. I came to the conclusion that this module was the culprit for some the brokenness being experienced so I attempted to come up with a tiny solution to try and solve a large sum of it that requires a bit less code. Know that I didn't find a way to retain some ids but I'm sure this change is rather negligible. The percentage of code covered goes up by 1% but it should be enough to help #1642 pass.
Are there changes in behavior for the user?
This change should only affect how contributions are handled as well as relieve us of some problems. There is a similar problem with multidict that I attempted to also get my hands into rather recently. While waiting this is where I decided to go to next so now I am here, seems yarl contains similar issues where coverage is almost completely broken in some areas.
Related issue number
#1642
Checklist