SPRINT Ontario - #122
Open
av-mads wants to merge 26 commits into
Open
Conversation
* Add selectionStyle prop to support background color selection mode
Introduce a new `selectionStyle` prop ("checkbox" | "background") across option components to allow alternative visual feedback when options are selected. When set to "background", selected options display with a colored background instead of the default checkbox styling.
- Add `selectionStyle` prop to AVOptionCheckbox, AVOptionSelect, AVOption, and AVBlankOption components
- Implement `AVOptionCheckbox--checked-white` and `AVOption--selected-background` styles for background selection
* Add comprehensive test coverage for new ballot customization props
Add test cases for `reverseOption`, `selectionStyle`, `partialResults`, `imageOption`, `includeLazyErrors`, and `displayErrorModal` props across AVOptionCheckbox, AVOptionSelect, AVBlankOption, AVOption, AVBallot, and AVSplitHelper components. Tests verify default values, prop passing to child components, and correct application of styles and classes.
- Add tests for `selectionStyle` prop defaulting to "checkbox" and applying "
* Wrap AVSubmissionHelper template in container div to fix layout issues
Add outer wrapper div to AVSubmissionHelper component template to properly contain sticky-bottom positioning and modal elements. This prevents layout conflicts when the component is used within flex or grid containers.
* Remove CSS class catalog documentation files
Delete both Word and Markdown versions of the CSS class reference catalog. This documentation is being removed from the repository.
* Bump version to 5.5.9-alpha-1
* Pass reverseOption and selectionStyle props to AVBlankOption component
Add missing `reverseOption` and `selectionStyle` prop bindings to AVBlankOption component in AVBallot template to ensure consistent styling behavior across all option types.
* Bump version to 5.5.9-beta.1
* Increase max props limit to 15 and add void return type to dismissErrorModal
* Add flex-row-reverse class for single-vote reversed options
Apply `flex-row-reverse` class when `votesAllowedPerOption` is 1 and `reverseOption` is true to ensure proper layout for single-vote options in reversed mode.
* Fix bg-transparent class conflict with background selection style and add aria-modal attribute
Update AVOption to prevent bg-transparent class from overriding selected background styling in quadratic voting mode when selectionStyle is 'background'. Add aria-modal="true" attribute to error modal in AVSubmissionHelper for improved accessibility.
* Finish migrating to types library (#117)
* Bump axios from 1.15.0 to 1.16.0 (#116)
Bumps [axios](https://github.com/axios/axios) from 1.15.0 to 1.16.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.15.0...v1.16.0)
---
updated-dependencies:
- dependency-name: axios
dependency-version: 1.16.0
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [AB#28960] Relocate weight (#118)
* [AB#28960] Relocate weight
* Fix for quadratic on mobile
* Update sb
* Fix style
* pass required prop
* Make it optional to use on prefilled ballot f.ex.
* Add white text color enforcement to AVBlankOption selected state and fix error modal display logic
Update AVBlankOption to use !important on color properties and set --bs-heading-color variable to ensure white text is properly displayed when background selection style is active. Modify AVSubmissionHelper to only show inline errors when displayErrorModal is false, add watcher for displayErrorModal prop changes, and wrap modal elements in template tag for cleaner rendering.
* Add SelectionStyle type definition and update component prop types
Define SelectionStyle as a constant-based type in constants/components.ts and update all components using selectionStyle prop to use the new type instead of inline string literals. Add test coverage for displayErrorModal prop in AVSubmissionHelper and fix positioning classes for reversed multivote options in AVOption component.
* Bump version to 5.6.2-beta.1 and improve error modal accessibility
Update version from 5.5.9-beta.1 to 5.6.2-beta.1. Add error_modal_title translation key across all supported languages. Enhance error modal accessibility by changing role from 'dialog' to 'alertdialog', adding aria-labelledby and aria-describedby attributes, including visually-hidden h2 title element, and using t() helper for dismiss button text.
* Add Storybook controls for reverseOption, selectionStyle, and displayErrorModal props
Add boolean controls for reverseOption and displayErrorModal, and select controls for selectionStyle (with checkbox/background options) across AVOption, AVSubmissionHelper, AVBallot, and AVSplitHelper stories to enable interactive testing of these props in Storybook.
* Add reverseOption prop support to AVOptionCheckbox and AVBlankOption components
Add reverseOption prop to AVOptionCheckbox component with corresponding SCSS styles for reversed layout in both LTR and RTL directions, including adjusted margins and border-radius for exclusive error indicators. Pass reverseOption prop through AVBlankOption to its child AVOptionCheckbox instances. Add Storybook controls for reverseOption, selectionStyle, excluded, and invalid props across AVOptionCheckbox and AVBlankOption
* Add reverseOption and selectionStyle props to AVSummaryOption and AVPileSummary components
Add reverseOption and selectionStyle props to AVSummaryOption component with corresponding SCSS styles for background selection mode including white text enforcement. Update AVOptionCheckbox disabled state styles to preserve checked-white variant appearance. Add flex-row-reverse layout support for reversed options in AVSummaryOption. Pass reverseOption and selectionStyle props through AVPileSummary to child AVSummaryOption instances. Add
* Add white credit bar styling for background selection mode in AVOption
Add creditBarBgClass, creditBarOpacity, and creditBarPosition computed properties to AVOption component to handle credit bar styling when selectionStyle is 'background' and option is selected. Update credit bar to use white background with 0.3 opacity when selected in background mode, otherwise use ballot/danger colors with 0.1 opacity. Add z-1 class and position styling to credit bar element.
* Add white background styling to counter interface in background selection mode
Update AVOption to apply gray-100 background with full-width styling to counter interface when selectionStyle is 'background' and option has votes. Add SCSS rules for AVOption--singlevote.bg-white class to set background color, remove border radius, and adjust alignment for consistent appearance in background selection mode.
* Add justify-content-start styling for reversed multivote options in AVOption and AVSummaryOption
Update AVOption to use justify-content-start for reversed multivote aside and footer layouts. Add AVOption--multivote-footer-reversed class with padding styling. Simplify flex-column logic by removing reverseOption condition. Update AVSummaryOption card-body and card-footer to conditionally apply justify-content-start when reverseOption is true, removing redundant justify-content-between condition for reversed options.
* Add right-to-left layout support for gallery mode in AVOption and AVSummaryOption components
Update AVOption to conditionally apply align-items-end, align-items-sm-end, and flex-sm-row-reverse classes when reverseOption is true in gallery mode. Add order-last class to option image when reversed. Update AVSummaryOption to apply align-items-end and justify-content-end classes for reversed gallery layout, add margin styling for reversed checkbox positioning, and apply order-last class with reversed
* Fix version string formatting by removing extra space in package.json
Remove extraneous space between version number and beta suffix, changing "5.6.2 -beta.1" to "5.6.2-beta.1" for proper semver compliance.
* Update error modal to display all errors, add keyboard support, and fix Welsh translation
Add support for displaying multiple error messages in modal instead of only showing first error. Implement automatic focus management by focusing dismiss button when modal opens. Add ESC key handler to close modal. Conditionally render horizontal rule only when errors exist and modal is not displayed. Update Welsh translation for error_modal_dismiss from "Gwneud yn Ddistryw" to "Diystyru".
* Add flex-column-reverse support for reversed multivote options in AVOption
Update AVOption to conditionally apply flex-column-reverse class when votesAllowedPerOption > 1 and reverseOption is true, replacing previous unconditional flex-column behavior. Maintain existing flex-sm-row and flex-sm-row-reverse responsive layout logic for options with 5 or fewer votes or counter interface enabled.
* chore(release): 5.6.2-beta.2
* Add Theme type definition and THEMES constant for light/dark theme support
Add THEMES constant array with 'light' and 'dark' values to components constants. Export Theme type derived from THEMES constant in components types. Export THEMES constant from constants module.
* Update @assemblyvoting/types to version 1.0.0-beta.7 and remove local Theme type definition
Remove THEMES constant and Theme type from components constants and types as they are now provided by @assemblyvoting/types package. Update package.json to use @assemblyvoting/types version 1.0.0-beta.7.
* chore(release): 5.6.2-beta.4
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Javier Pavon <javier.pavon@lumiglobal.com>
…ections (#121) * Restructure error modal layout with proper header, body, and footer sections Replace centered single-body modal layout with standard Bootstrap modal structure including separate header with icon and title, scrollable body for error messages, and footer with dismiss button. Add transition wrapper, click-outside-to-close functionality, and custom backdrop styling with z-index 1050 to ensure modal appears above sticky-bottom elements. Update modal-title to use h5 element instead of visually-hidden h * Update error modal backdrop styling and semantic HTML elements Replace transition tag attribute with semantic HTML, change modal body from main to div element, and add custom backdrop class with rgba black background at 0.5 opacity. Update comment formatting for z-index explanation to use proper capitalization of "Bootstrap". * Add fade transition to error modal and increase z-index to 1055 Add modal-enter-active, modal-leave-active, modal-enter-from, and modal-leave-to CSS classes with 0.15s linear opacity transition for smooth fade effect. Increase error modal z-index from 1050 to 1055 to ensure proper layering above other modal elements.
* Add selectionMode prop and maxSelectionsReached blocking behavior to option components
Add `selectionMode` prop ("checkbox" | "radio") to AVOption and AVBlankOption components to support radio button semantics with appropriate ARIA attributes (role="radio", aria-checked). Add `maxSelectionsReached` prop to AVOption to block selection of unselected options when maximum selections reached (except in radio mode). Implement AVOption--blocked styles with reduced opacity and disabled pointer events. Add
* Remove displayErrorModal prop and error modal functionality from AVSubmissionHelper and related components
Remove displayErrorModal prop from AVSubmissionHelper, AVBallot, and AVSplitHelper components along with all associated error modal rendering logic, state management, and event handlers. Remove modal backdrop, dialog markup, dismiss button, keyboard handlers, and focus management code. Remove displayErrorModal prop from Storybook controls and test coverage. Simplify inline error display logic by
* Change validation policy from mixed to full in AVSplitHelper WithValidationPolicyMixed story
* Add feedbackParams support to validation policy feedback messages
Add optional `feedbackParams` property to ValidationResult interface and pass it to translation function calls in AVSubmissionHelper and AVPileSummary components. Include `min_marks` parameter in undervote_below_min feedback messages to enable dynamic translation interpolation.
* Remove validation policies documentation file
* Move i18n initialization before useValidationPolicy calls and pass locale parameter
Relocate i18n setup code to execute before useValidationPolicy composable calls in AVBallot, AVPileSummary, and AVSplitHelper components. Pass i18nLocale computed property as fourth parameter to useValidationPolicy to enable locale-aware validation feedback. Add resolveLocalizedMessage helper function to resolve localized messages from validation policy feedback. Support isRawMessage flag in ValidationResult interface
* Clear explicit blank when selecting option in radio mode and clear option selections when selecting blank in radio mode
Update toggleBlank to clear optionSelections array when explicit blank is selected in radio mode. Update toggleOption to clear explicitBlank flag when an option is selected with amount > 0 in radio mode. This ensures mutually exclusive selection behavior between blank vote and options in radio button mode.
* Change warning text color from text-warning to text-white in AVSubmissionHelper and from text-warning to text-warning-emphasis in AVPileSummary
Update AVSubmissionHelper to use text-white for both warning and blocked states instead of separate text-warning and text-white classes. Update AVPileSummary to use text-warning-emphasis instead of text-warning for warning state to improve contrast and readability.
* Bump version to 5.6.2-beta.7
* Refactor useValidationPolicy composable by extracting helper functions and adding return type interface
Extract handleBlankVote and handleOvervote functions from evaluateScenario switch cases to reduce complexity. Add UseValidationPolicyReturn interface to explicitly type the composable's return value. Update resolveLocalizedMessage to return string | null instead of string | undefined for consistency. Increase max props limit from 15 to 18 in oxlint configuration.
* Remove role and aria-checked attributes from AVOption and AVBlankOption components
Remove role="radio" and aria-checked attributes from both AVOption and AVBlankOption components. These ARIA attributes were previously added to support radio button semantics but are now being removed.
* Remove activeScreen prop from AVSubmissionHelper and merge default validation policies with custom policies
Remove unused activeScreen prop and FeedbackScreen type import from AVSubmissionHelper component. Update useValidationPolicy composable to merge default validation policies with custom policies instead of replacing them entirely. Support raw feedback messages by checking isRawMessage flag before translation in AVSubmissionHelper and AVPileSummary. Change default overvote behavior from 'allow_with_error' to
* Remove pointer-events: none from blocked AVOption, remove radiogroup role from AVBallot options container, and always block blank votes regardless of minMarks value
Update BlankVoteFeedbackPolicy message type from Record<string, string> to LocalString for consistency. Change handleBlankVote to always return blocked: true and allowed/warning: false instead of conditionally checking minMarks value.
* Remove selectionMode prop from AVBlankOption, add displayErrorModal deprecation warning to AVSubmissionHelper, fix selection blocking logic in AVBallot to check total selections and increase condition, clear pendingAlerts when leaving summary state in AVPileSummary, and remove hasPendingAlerts check from readyForSubmission in AVSplitHelper
* Change AVOptionCheckbox tabindex from undefined to -1 when disabled, replace forEach with for...of loops in AVSubmissionHelper and AVPileSummary, convert console.warn to comment, remove unused OptionSelection import, add explicit return type annotations to watch callback, and change early return to continue in optionSummaries loop
* Move finalAmount calculation before blockSelectionEnabled check to fix selection blocking logic
Calculate finalAmount and wouldIncreaseTotal before checking blockSelectionEnabled condition instead of after, ensuring the blocking logic correctly evaluates whether the selection would increase the total count.
* Bump version to 5.6.2-beta.8, add explanatory comments to AVOption click blocking logic and AVBallot toggleOption method
Add detailed comments explaining click blocking behavior in AVOption when selection limit is reached in multi-select mode. Add comprehensive inline documentation to AVBallot toggleOption method explaining selection state management, amount calculation, blocking conditions, and radio mode behavior.
* Bump version to 5.6.2-beta.9, extract isBlocked computed property in AVOption, add aria-disabled attribute, fix selection blocking logic in AVBallot, update submission helper background color conditions to check for blocked results, and remove unused selectionMode prop from AVBlankOption
* Finish migrating to types library (#117) * Bump axios from 1.15.0 to 1.16.0 (#116) Bumps [axios](https://github.com/axios/axios) from 1.15.0 to 1.16.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.15.0...v1.16.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.16.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [AB#28960] Relocate weight (#118) * [AB#28960] Relocate weight * Fix for quadratic on mobile * Update sb * Fix style * pass required prop * Make it optional to use on prefilled ballot f.ex. * review --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump version to 5.6.2-beta.10, add blocked-click event emission when selection limit reached, add overvoteAlertBased computed property to useValidationPolicy, and emit synthetic overvote alert on blocked-click when alert-based feedback is enabled Add blocked-click event to AVOption emits and emit it in handleOptionClick when maxSelectionsReached and option is unselected in checkbox mode. Pass blocked-click event through nested AVOption instances. Add handleBlockedClick method to AVBallot that creates * Add test for blocked-click emission on parent options, export handleOvervote function, fix pending alerts concatenation in handleBlockedClick, and add ValidationResult type annotations to AVSplitHelper event handlers * Add early return guards to AVOption click handler and remove duplicate pendingAlerts update in AVBallot handleBlockedClick Add disabled, observerMode, selectable, and counterInterface checks at the start of handleOptionClick to prevent unnecessary processing. Remove redundant pendingAlerts update emission from handleBlockedClick since show-overvote-alert already handles alert propagation. * Add pendingAlerts update emission to AVBallot handleBlockedClick method Emit update:pendingAlerts event with alertResult array before emitting show-overvote-alert to ensure pending alerts state is synchronized when blocked click triggers overvote alert. --------- Co-authored-by: av-javier <javier.pavon@lumiglobal.com>
…or validation feedback messages, implement resolveReviewFeedbackMessage helper to check for review_* prefixed translations before falling back to default keys, and update AVPileSummary to map pending alerts with review keys when in summary state (#128)
…es (#132) * Bump version to 5.6.2-beta.12 and fix Bootstrap CSS variable references by adding missing -- prefix to bg-gray-300 class usages in AVVerticalStep, AVSplitWeightHelper, AVSubmissionHelper, and AVSplitHelper components * Fix Bootstrap CSS variable references by adding missing bg- prefix to gray-300 class usages in AVSplitWeightHelper, AVSubmissionHelper, and AVSplitHelper components
…into sync-ontario-with-main
Sync ontario with main
…on site (#134) * Bump version to 5.6.2-beta.12 and fix Bootstrap CSS variable references by adding missing -- prefix to bg-gray-300 class usages in AVVerticalStep, AVSplitWeightHelper, AVSubmissionHelper, and AVSplitHelper components * Fix Bootstrap CSS variable references by adding missing bg- prefix to gray-300 class usages in AVSplitWeightHelper, AVSubmissionHelper, and AVSplitHelper components
* [AB#29153][AB#28876] Bug fixes + some maintenance (#136) * Refactor to reduce complexity * fix * [AB#28876] Multiple votes per option appears differently on the confirmation page * Another one * [AB#29153] Check box breaks when a parent list name is too long in gallery view * More RTL bug fixes * Update sb * Try changing the engine for accessibility testing * slightly change flow * Bump * Bump shell-quote from 1.8.2 to 1.8.4 (#135) Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.2 to 1.8.4. - [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md) - [Commits](ljharb/shell-quote@v1.8.2...v1.8.4) --- updated-dependencies: - dependency-name: shell-quote dependency-version: 1.8.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [AB#29153][AB#28876] Bug fixes + some maintenance (#136) * Refactor to reduce complexity * fix * [AB#28876] Multiple votes per option appears differently on the confirmation page * Another one * [AB#29153] Check box breaks when a parent list name is too long in gallery view * More RTL bug fixes * Update sb * Try changing the engine for accessibility testing * slightly change flow * Bump * Bump shell-quote from 1.8.2 to 1.8.4 (#135) Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.2 to 1.8.4. - [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md) - [Commits](ljharb/shell-quote@v1.8.2...v1.8.4) --- updated-dependencies: - dependency-name: shell-quote dependency-version: 1.8.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update test script to use unit project and fix write-in validation regex --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Javier Pavon <javier.pavon@lumiglobal.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the ballot UI’s customization and validation capabilities by introducing a configurable validation policy (with inline/alert feedback), adding selectionStyle / reverseOption support across option components, and updating the test infrastructure to run Storybook tests via Vitest + Playwright.
Changes:
- Add
ValidationPolicytypes +useValidationPolicycomposable, and integrate policy results into ballot/split/summary flows. - Add
selectionStyle(“checkbox” | “background”) andreverseOptionprops throughout option components, with corresponding styling and tests. - Rework test setup to Vitest multi-project (unit + Storybook) using
@storybook/addon-vitestand@vitest/browser-playwright.
Reviewed changes
Copilot reviewed 46 out of 48 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.shims.d.ts | Adds Vitest browser Playwright types. |
| vitest.config.ts | Splits Vitest into unit + storybook projects and adds Storybook addon plugin + browser provider. |
| src/types/validationPolicy.ts | Introduces validation policy/result types and augments ContestContent. |
| src/types/index.ts | Re-exports validation policy types. |
| src/types/components.ts | Adds SelectionStyle type derived from constants. |
| src/examples/validationPolicy.ts | Adds example presets for validation policies. |
| src/examples/index.ts | Exposes getValidationPolicy in examples barrel. |
| src/constants/components.ts | Adds SELECTION_STYLES constant. |
| src/composables/useValidationPolicy.ts | Implements policy evaluation + helpers for inline results/alerts. |
| src/composables/useValidationPolicy.spec.ts | Adds unit tests for validation policy behavior. |
| src/components/templates/AVSplitHelper/AVSplitHelper.vue | Wires reverseOption/selectionStyle through and adds alert-related emits. |
| src/components/templates/AVSplitHelper/AVSplitHelper.stories.ts | Adds Storybook controls + stories for validation policy presets. |
| src/components/templates/AVSplitHelper/AVSplitHelper.spec.ts | Adds prop-passing tests (incl. partialResults/imageOption/etc). |
| src/components/organisms/AVPileSummary/AVPileSummary.vue | Uses validation policy in review context and emits pending alerts + inline feedback. |
| src/components/organisms/AVPileSummary/AVPileSummary.stories.ts | Adds controls/stories for reverse/background + policy scenarios. |
| src/components/organisms/AVBallot/AVBallot.vue | Integrates useValidationPolicy, passes policy results, blocks selection when max reached, emits overvote alerts. |
| src/components/organisms/AVBallot/AVBallot.stories.ts | Adds controls/stories for reverse/background + policy scenarios. |
| src/components/organisms/AVBallot/AVBallot.spec.ts | Adds tests for new props and validation-policy-related events/props. |
| src/components/molecules/AVSummaryOption/AVSummaryOption.vue | Adds reverse/background support to summary option UI. |
| src/components/molecules/AVSummaryOption/AVSummaryOption.stories.ts | Adds Storybook controls/stories for new props. |
| src/components/molecules/AVSummaryOption/AVSummaryOption.scss | Adds background-selection styling in summary mode. |
| src/components/molecules/AVSubmissionHelper/AVSubmissionHelper.vue | Adds policy inline rendering; adjusts wrapper/layout and locale switching. |
| src/components/molecules/AVSubmissionHelper/AVSubmissionHelper.stories.ts | Adds stories for policy inline states. |
| src/components/molecules/AVSubmissionHelper/AVSubmissionHelper.spec.ts | Adds tests for policy inline rendering. |
| src/components/molecules/AVSubmissionHelper/AVSubmissionHelper.scss | Adds modal/backdrop transition styles. |
| src/components/molecules/AVSubmissionHelper/AVSubmissionHelper.messages.ts | Adds new translation keys for policy feedback + modal text. |
| src/components/molecules/AVOption/AVOption.vue | Adds reverse/background style support, blocked-click behavior, and credit-bar styling updates. |
| src/components/molecules/AVOption/AVOption.stories.ts | Adds new stories for reverse/background and policy-related modes. |
| src/components/molecules/AVOption/AVOption.spec.ts | Adds tests for reverse/background behavior and blocked-click emit. |
| src/components/molecules/AVOption/AVOption.scss | Adds styling for reversed multivote + selected background + blocked state. |
| src/components/molecules/AVBlankOption/AVBlankOption.vue | Adds reverse/background selection support and passes props to checkbox. |
| src/components/molecules/AVBlankOption/AVBlankOption.stories.ts | Adds controls for new props. |
| src/components/molecules/AVBlankOption/AVBlankOption.spec.ts | Adds tests for reverse/background behavior. |
| src/components/molecules/AVBlankOption/AVBlankOption.scss | Adds background-selection styling for blank option. |
| src/components/atoms/AVVerticalStep/AVVerticalStep.scss | Fixes CSS variable reference. |
| src/components/atoms/AVOptionSelect/AVOptionSelect.vue | Adds selectionStyle prop affecting color/stroke. |
| src/components/atoms/AVOptionSelect/AVOptionSelect.spec.ts | Adds tests for background vs checkbox selection style. |
| src/components/atoms/AVOptionSelect/AVOptionSelect.scss | Adds .text-ballot helper styling. |
| src/components/atoms/AVOptionCheckbox/AVOptionCheckbox.vue | Adds selectionStyle + reverse support and adjusts checked styling. |
| src/components/atoms/AVOptionCheckbox/AVOptionCheckbox.stories.ts | Adds controls for new props and actions. |
| src/components/atoms/AVOptionCheckbox/AVOptionCheckbox.spec.ts | Adds tests for selectionStyle variants. |
| src/components/atoms/AVOptionCheckbox/AVOptionCheckbox.scss | Adds checked-white styling + reversed exclusive indicator tweaks. |
| package.json | Updates version, scripts, Storybook/Vitest deps, and adds Playwright deps. |
| .storybook/test-runner.ts | Removes legacy Storybook test-runner (axe-playwright) config. |
| .storybook/main.ts | Switches addons (removes coverage/chromatic, adds addon-vitest). |
| .oxlintrc.json | Adjusts prop limit and changes eslint/no-undefined severity. |
| .circleci/config.yml | Updates Playwright image and switches Storybook testing workflow. |
Comment on lines
+25
to
29
| "vue/max-props": ["error", { "maxProps": 18 }], // As these are independent components that don't rely on stores, etc. we need to allow more props. | ||
| "eslint/no-shadow": "error", | ||
| "eslint/no-unneeded-ternary": "error", | ||
| "eslint/no-undefined": "error", | ||
| // Start fixing later |
Comment on lines
515
to
+520
| }" | ||
| :style="coloredEdgeStyle" | ||
| :aria-disabled="isBlocked || undefined" | ||
| :aria-label="`${t('js.components.AVOption.aria_labels.option')} ${getMeaningfulLabel(option as unknown as IterableObject, i18nLocale, t('js.components.AVOption.aria_labels.option'))}`" | ||
| data-test="option-section" | ||
| @click="toggleFromOption(false)" | ||
| @click="handleOptionClick" |
Comment on lines
174
to
176
| const writeInInvalid = computed(() => { | ||
| const regexp = /[^\p{L}\p{N}\p{Z},.'‘()?!@€£¥\n]/gu; | ||
| const regexp = /[^\p{L}\p{N}\p{Z},.''()?!@€£¥\n]/gu; | ||
| return ( |
Comment on lines
+39
to
+46
| policyInlineResults: { | ||
| type: Array as PropType<ValidationResult[]>, | ||
| default: () => [], | ||
| }, | ||
| displayErrorModal: { | ||
| type: Boolean, | ||
| default: false, | ||
| }, |
* Improve accessibility and code quality: add alt attributes, simplify translations, refactor array generation, and fix TypeScript config - Add alt attribute to file preview image in AVFileInput - Simplify option_image aria-label translations across all languages to just "Option" - Add aria-label to option anchor element in AVOption - Add alt and title attributes to images and iframes in AVResultOption and AVResourceSection - Refactor array generation to use Array.from with length parameter in AV * Add vuejs-accessibility ESLint plugin with warnings, add vitest-axe for accessibility testing, and fix option image alt text - Add eslint-plugin-vuejs-accessibility with flat/recommended config set to warn level - Add vitest-axe and @vitest/browser-playwright packages for accessibility testing - Update AVOptionSelect to conditionally set role="img" and aria-label attributes - Simplify option image alt text from "Option image" to "Option" in AVOption test - Reorder package.json dependencies alphabetically * Add optional axeOptions parameter to mountForA11y function to allow custom accessibility testing rules configuration * Fix Polish translation for option_image aria-label and add error prop to AVBlankOption accessibility test - Correct Polish translation from Romanian "Imagine opțiune" to "Obraz opcji" - Add error prop to invalid state test in AVBlankOption accessibility spec * Bump version to 5.6.6-beta.2 and configure Storybook accessibility testing to pin WCAG conformance levels and disable page-level rules for isolated component stories - Pin axe-core to evaluate specific WCAG tags (wcag2a, wcag2aa, wcag21a, wcag21aa, best-practice) for deterministic coverage across upgrades - Disable landmark-one-main, page-has-heading-one, and bypass rules as they are page-level concerns not applicable to isolated component stories - Add explanatory comments for configuration placement and rule * Remove TypeScript build info files from version control * Add TypeScript build info files to gitignore, fix ESLint accessibility config to preserve rule options, improve option aria-label, and configure TypeScript build info paths - Add *.tsbuildinfo to .gitignore to exclude TypeScript incremental build files - Fix ESLint accessibility config to preserve rule configuration arrays when converting to warnings - Update AVOption aria-label from option.reference to title for better accessibility - Configure tsBuildInfoFile paths in tsconfig.app.json and tsconfig.vi * Enable incremental TypeScript compilation in app and vitest configs to improve build performance * Fix typo in accessibility comments and simplify optionGroups array generation - Correct spelling from "accesibility" to "accessibility" in Storybook parameters comments - Refactor optionGroups computation to use Array.from with mapping function instead of post-creation loop - Add nullish coalescing operator for safer crosses property access * Add condition to hide horizontal rule when no options are chosen despite policy inline results being present
* [AB#29153][AB#28876] Bug fixes + some maintenance (#136) * Refactor to reduce complexity * fix * [AB#28876] Multiple votes per option appears differently on the confirmation page * Another one * [AB#29153] Check box breaks when a parent list name is too long in gallery view * More RTL bug fixes * Update sb * Try changing the engine for accessibility testing * slightly change flow * Bump * Bump shell-quote from 1.8.2 to 1.8.4 (#135) Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.2 to 1.8.4. - [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md) - [Commits](ljharb/shell-quote@v1.8.2...v1.8.4) --- updated-dependencies: - dependency-name: shell-quote dependency-version: 1.8.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Configure hot reload for ui-library in devbox (#140) * Fix broken css variable (#141) * Bump undici from 7.24.1 to 7.28.0 (#142) Bumps [undici](https://github.com/nodejs/undici) from 7.24.1 to 7.28.0. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v7.24.1...v7.28.0) --- updated-dependencies: - dependency-name: undici dependency-version: 7.28.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump form-data from 4.0.5 to 4.0.6 (#144) Bumps [form-data](https://github.com/form-data/form-data) from 4.0.5 to 4.0.6. - [Changelog](https://github.com/form-data/form-data/blob/master/CHANGELOG.md) - [Commits](form-data/form-data@v4.0.5...v4.0.6) --- updated-dependencies: - dependency-name: form-data dependency-version: 4.0.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> * Bump @babel/core from 7.29.0 to 7.29.7 (#145) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.29.0 to 7.29.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.29.7/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-version: 7.29.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> * Bump vite from 7.3.2 to 7.3.5 (#143) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.3.2 to 7.3.5. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v7.3.5/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.3.5/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.3.5 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix RTL positioning for multi-vote crosses in gallery mode by accounting for reverseOption state * Bump version to 5.7.0-ontario-beta.2 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ebadia <enric.badia@gmail.com>
* Add inlineMessage support to BlankVoteFeedbackPolicy and implement on_screen_message_and_alert feedback type splitting - Add optional inlineMessage field to BlankVoteFeedbackPolicy interface - Implement logic to split on_screen_message_and_alert into separate inline and alert results - Use inlineMessage for on_screen_message feedback type, falling back to message when not provided - Use message field for alert feedback type - Add comprehensive test coverage for new message handling scenarios - Update validation * Bump version to 5.7.0-ontario-beta.3
* Bump version to 5.7.1 * Bump version to 5.7.1-ontario
…typo (#149) - Extract prerelease tag from version string using regex pattern to capture any suffix after final dash - Support custom prerelease tags beyond just alpha/beta (e.g., ontario) - Fix typo in release publish echo message ("with to" -> "to")
* [AB#29153][AB#28876] Bug fixes + some maintenance (#136) * Refactor to reduce complexity * fix * [AB#28876] Multiple votes per option appears differently on the confirmation page * Another one * [AB#29153] Check box breaks when a parent list name is too long in gallery view * More RTL bug fixes * Update sb * Try changing the engine for accessibility testing * slightly change flow * Bump * Bump shell-quote from 1.8.2 to 1.8.4 (#135) Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.2 to 1.8.4. - [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md) - [Commits](ljharb/shell-quote@v1.8.2...v1.8.4) --- updated-dependencies: - dependency-name: shell-quote dependency-version: 1.8.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Configure hot reload for ui-library in devbox (#140) * Fix broken css variable (#141) * Bump undici from 7.24.1 to 7.28.0 (#142) Bumps [undici](https://github.com/nodejs/undici) from 7.24.1 to 7.28.0. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v7.24.1...v7.28.0) --- updated-dependencies: - dependency-name: undici dependency-version: 7.28.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump form-data from 4.0.5 to 4.0.6 (#144) Bumps [form-data](https://github.com/form-data/form-data) from 4.0.5 to 4.0.6. - [Changelog](https://github.com/form-data/form-data/blob/master/CHANGELOG.md) - [Commits](form-data/form-data@v4.0.5...v4.0.6) --- updated-dependencies: - dependency-name: form-data dependency-version: 4.0.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> * Bump @babel/core from 7.29.0 to 7.29.7 (#145) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.29.0 to 7.29.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.29.7/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-version: 7.29.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> * Bump vite from 7.3.2 to 7.3.5 (#143) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.3.2 to 7.3.5. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v7.3.5/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.3.5/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.3.5 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ions (#151) * Bump version to 5.7.3-ontario and prevent blocked-click emission when deselecting options at max selections - Add handleCheckboxToggle function to check if option is being selected (checkedCount === 0) before emitting blocked-click - Emit blocked-click only when attempting to select a new option at max selections, not when deselecting - Replace direct toggleOption calls with handleCheckboxToggle for checkbox interactions - Add test coverage for blocked-click emission on direct checkbox clicks - Add * Add test coverage for multi-vote blocked-click emission and fix blocked-click logic to check vote increase instead of zero count - Change handleCheckboxToggle to emit blocked-click when amount > checkedCount.value instead of checkedCount.value === 0 - Add test for blocked-click emission when increasing votes in multi-vote mode at max selections - Add test to verify no blocked-click emission when decreasing votes in multi-vote mode at max selections
* Bump version to 5.8.1-ontario.beta1 and prevent option selection when clicking links or videos - Bump version from 5.7.3-ontario to 5.8.1-ontario.beta1 - Add event parameter to handleOptionClick function - Check if click target is within an anchor or video element and return early to prevent option selection - Preserve existing disabled, observer mode, selectable, and counter interface checks * Refactor handleOptionClick to use instanceof check for Element type guard instead of type assertion
* [AB#29153][AB#28876] Bug fixes + some maintenance (#136) * Refactor to reduce complexity * fix * [AB#28876] Multiple votes per option appears differently on the confirmation page * Another one * [AB#29153] Check box breaks when a parent list name is too long in gallery view * More RTL bug fixes * Update sb * Try changing the engine for accessibility testing * slightly change flow * Bump * Bump shell-quote from 1.8.2 to 1.8.4 (#135) Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.2 to 1.8.4. - [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md) - [Commits](ljharb/shell-quote@v1.8.2...v1.8.4) --- updated-dependencies: - dependency-name: shell-quote dependency-version: 1.8.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Configure hot reload for ui-library in devbox (#140) * Fix broken css variable (#141) * Bump undici from 7.24.1 to 7.28.0 (#142) Bumps [undici](https://github.com/nodejs/undici) from 7.24.1 to 7.28.0. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v7.24.1...v7.28.0) --- updated-dependencies: - dependency-name: undici dependency-version: 7.28.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump form-data from 4.0.5 to 4.0.6 (#144) Bumps [form-data](https://github.com/form-data/form-data) from 4.0.5 to 4.0.6. - [Changelog](https://github.com/form-data/form-data/blob/master/CHANGELOG.md) - [Commits](form-data/form-data@v4.0.5...v4.0.6) --- updated-dependencies: - dependency-name: form-data dependency-version: 4.0.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> * Bump @babel/core from 7.29.0 to 7.29.7 (#145) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.29.0 to 7.29.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.29.7/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-version: 7.29.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> * Bump vite from 7.3.2 to 7.3.5 (#143) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.3.2 to 7.3.5. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v7.3.5/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.3.5/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.3.5 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [AB#28769][FIFA] self vote prevention (#152) * init * rework * fixing comments * fix tests * removed unnessesary code * updated version * updated js-client * clean up --------- Co-authored-by: Georgi Naydev <Georgi.Naydev@lumiglobal.com> * Bump ws from 8.18.1 to 8.21.1 Bumps [ws](https://github.com/websockets/ws) from 8.18.1 to 8.21.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.18.1...8.21.1) --- updated-dependencies: - dependency-name: ws dependency-version: 8.21.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Fix typos (#159) * Fix typos * Improve docs for AI * fix ui (#158) fix ui 2 * Make AVFileInput reactive to dark mode * Prettier * Better handling of localization (test) * Migrate to use bootstrap native dark mode * Updat docs + colors palette * try * specs * More * bump * Bump shell-quote from 1.8.4 to 1.10.0 (#155) Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.8.4 to 1.10.0. - [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md) - [Commits](ljharb/shell-quote@v1.8.4...v1.10.0) --- updated-dependencies: - dependency-name: shell-quote dependency-version: 1.10.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump postcss from 8.5.12 to 8.5.25 (#161) Bumps [postcss](https://github.com/postcss/postcss) from 8.5.12 to 8.5.25. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.5.12...8.5.25) --- updated-dependencies: - dependency-name: postcss dependency-version: 8.5.25 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> * Bump immutable from 5.1.5 to 5.1.9 (#156) Bumps [immutable](https://github.com/immutable-js/immutable-js) from 5.1.5 to 5.1.9. - [Release notes](https://github.com/immutable-js/immutable-js/releases) - [Changelog](https://github.com/immutable-js/immutable-js/blob/main/CHANGELOG.md) - [Commits](immutable-js/immutable-js@v5.1.5...v5.1.9) --- updated-dependencies: - dependency-name: immutable dependency-version: 5.1.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> * increase coverage * Bump @assemblyvoting/types from 1.0.6 to 1.2.0 * yarn lock updated * Bump version to 5.8.1-ontario * Bump version to 5.9.0-ontario.beta0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alexis Toledo <112619860+av-alexistoledo@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Georgi Naydev <146313291+CyberIce2077@users.noreply.github.com> Co-authored-by: Georgi Naydev <Georgi.Naydev@lumiglobal.com> Co-authored-by: ebadia <enric.badia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new
selectionStyleprop ("checkbox" | "background") across option components to allow alternative visual feedback when options are selected. When set to "background", selected options display with a colored background instead of the default checkbox styling.selectionStyleprop to AVOptionCheckbox, AVOptionSelect, AVOption, and AVBlankOption componentsAVOptionCheckbox--checked-whiteandAVOption--selected-backgroundstyles for background selectionAdd test cases for
reverseOption,selectionStyle,partialResults,imageOption,includeLazyErrors, anddisplayErrorModalprops across AVOptionCheckbox, AVOptionSelect, AVBlankOption, AVOption, AVBallot, and AVSplitHelper components. Tests verify default values, prop passing to child components, and correct application of styles and classes.selectionStyleprop defaulting to "checkbox" and applying "Add outer wrapper div to AVSubmissionHelper component template to properly contain sticky-bottom positioning and modal elements. This prevents layout conflicts when the component is used within flex or grid containers.
Delete both Word and Markdown versions of the CSS class reference catalog. This documentation is being removed from the repository.
Bump version to 5.5.9-alpha-1
Pass reverseOption and selectionStyle props to AVBlankOption component
Add missing
reverseOptionandselectionStyleprop bindings to AVBlankOption component in AVBallot template to ensure consistent styling behavior across all option types.Bump version to 5.5.9-beta.1
Increase max props limit to 15 and add void return type to dismissErrorModal
Add flex-row-reverse class for single-vote reversed options
Apply
flex-row-reverseclass whenvotesAllowedPerOptionis 1 andreverseOptionis true to ensure proper layout for single-vote options in reversed mode.Update AVOption to prevent bg-transparent class from overriding selected background styling in quadratic voting mode when selectionStyle is 'background'. Add aria-modal="true" attribute to error modal in AVSubmissionHelper for improved accessibility.
Finish migrating to types library (Finish migrating to types library #117)
Bump axios from 1.15.0 to 1.16.0 (Bump axios from 1.15.0 to 1.16.0 #116)
Bumps axios from 1.15.0 to 1.16.0.
updated-dependencies:
[AB#28960] Relocate weight ([AB#28960] Relocate weight #118)
[AB#28960] Relocate weight
Fix for quadratic on mobile
Update sb
Fix style
pass required prop
Make it optional to use on prefilled ballot f.ex.
Add white text color enforcement to AVBlankOption selected state and fix error modal display logic
Update AVBlankOption to use !important on color properties and set --bs-heading-color variable to ensure white text is properly displayed when background selection style is active. Modify AVSubmissionHelper to only show inline errors when displayErrorModal is false, add watcher for displayErrorModal prop changes, and wrap modal elements in template tag for cleaner rendering.
Define SelectionStyle as a constant-based type in constants/components.ts and update all components using selectionStyle prop to use the new type instead of inline string literals. Add test coverage for displayErrorModal prop in AVSubmissionHelper and fix positioning classes for reversed multivote options in AVOption component.
Update version from 5.5.9-beta.1 to 5.6.2-beta.1. Add error_modal_title translation key across all supported languages. Enhance error modal accessibility by changing role from 'dialog' to 'alertdialog', adding aria-labelledby and aria-describedby attributes, including visually-hidden h2 title element, and using t() helper for dismiss button text.
Add boolean controls for reverseOption and displayErrorModal, and select controls for selectionStyle (with checkbox/background options) across AVOption, AVSubmissionHelper, AVBallot, and AVSplitHelper stories to enable interactive testing of these props in Storybook.
Add reverseOption prop to AVOptionCheckbox component with corresponding SCSS styles for reversed layout in both LTR and RTL directions, including adjusted margins and border-radius for exclusive error indicators. Pass reverseOption prop through AVBlankOption to its child AVOptionCheckbox instances. Add Storybook controls for reverseOption, selectionStyle, excluded, and invalid props across AVOptionCheckbox and AVBlankOption
Add reverseOption and selectionStyle props to AVSummaryOption component with corresponding SCSS styles for background selection mode including white text enforcement. Update AVOptionCheckbox disabled state styles to preserve checked-white variant appearance. Add flex-row-reverse layout support for reversed options in AVSummaryOption. Pass reverseOption and selectionStyle props through AVPileSummary to child AVSummaryOption instances. Add
Add creditBarBgClass, creditBarOpacity, and creditBarPosition computed properties to AVOption component to handle credit bar styling when selectionStyle is 'background' and option is selected. Update credit bar to use white background with 0.3 opacity when selected in background mode, otherwise use ballot/danger colors with 0.1 opacity. Add z-1 class and position styling to credit bar element.
Update AVOption to apply gray-100 background with full-width styling to counter interface when selectionStyle is 'background' and option has votes. Add SCSS rules for AVOption--singlevote.bg-white class to set background color, remove border radius, and adjust alignment for consistent appearance in background selection mode.
Update AVOption to use justify-content-start for reversed multivote aside and footer layouts. Add AVOption--multivote-footer-reversed class with padding styling. Simplify flex-column logic by removing reverseOption condition. Update AVSummaryOption card-body and card-footer to conditionally apply justify-content-start when reverseOption is true, removing redundant justify-content-between condition for reversed options.
Update AVOption to conditionally apply align-items-end, align-items-sm-end, and flex-sm-row-reverse classes when reverseOption is true in gallery mode. Add order-last class to option image when reversed. Update AVSummaryOption to apply align-items-end and justify-content-end classes for reversed gallery layout, add margin styling for reversed checkbox positioning, and apply order-last class with reversed
Remove extraneous space between version number and beta suffix, changing "5.6.2 -beta.1" to "5.6.2-beta.1" for proper semver compliance.
Add support for displaying multiple error messages in modal instead of only showing first error. Implement automatic focus management by focusing dismiss button when modal opens. Add ESC key handler to close modal. Conditionally render horizontal rule only when errors exist and modal is not displayed. Update Welsh translation for error_modal_dismiss from "Gwneud yn Ddistryw" to "Diystyru".
Update AVOption to conditionally apply flex-column-reverse class when votesAllowedPerOption > 1 and reverseOption is true, replacing previous unconditional flex-column behavior. Maintain existing flex-sm-row and flex-sm-row-reverse responsive layout logic for options with 5 or fewer votes or counter interface enabled.
chore(release): 5.6.2-beta.2
Add Theme type definition and THEMES constant for light/dark theme support
Add THEMES constant array with 'light' and 'dark' values to components constants. Export Theme type derived from THEMES constant in components types. Export THEMES constant from constants module.
Remove THEMES constant and Theme type from components constants and types as they are now provided by @assemblyvoting/types package. Update package.json to use @assemblyvoting/types version 1.0.0-beta.7.