-
Notifications
You must be signed in to change notification settings - Fork 73
build: prepare PyAirbyte slim package boundaries #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Aaron ("AJ") Steers (aaronsteers)
wants to merge
8
commits into
main
Choose a base branch
from
devin/1779853894-airbyte-slim-packaging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8c12be3
build: prepare PyAirbyte slim package boundaries
devin-ai-integration[bot] 957093a
fix: restore Python 3.10 compatibility
devin-ai-integration[bot] 4081609
fix: preserve top-level lazy export typing
devin-ai-integration[bot] ba6dca9
fix: validate destinationType for destination dictionaries
devin-ai-integration[bot] 3352d81
build: add airbyte-slim release artifacts
devin-ai-integration[bot] 52bd2a8
ci: clarify release variant build step
devin-ai-integration[bot] 9cbc54d
build: harden slim package helper paths
devin-ai-integration[bot] bb99bc2
build: make slim package first-class
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Copyright (c) 2026 Airbyte, Inc., all rights reserved. | ||
| """Datetime parsing helpers.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from datetime import datetime, timezone | ||
|
|
||
|
|
||
| def parse_datetime(value: str | int) -> datetime: | ||
| """Parse an ISO datetime string or Unix timestamp as a timezone-aware datetime.""" | ||
| if isinstance(value, int) or ( | ||
| isinstance(value, str) | ||
| and (value.isdigit() or (value.startswith("-") and value[1:].isdigit())) | ||
| ): | ||
| return datetime.fromtimestamp(int(value), tz=timezone.utc) | ||
|
|
||
| if not isinstance(value, str): | ||
| raise TypeError(f"Could not parse datetime string: {value}") | ||
|
|
||
| normalized = value.replace("Z", "+00:00") | ||
| parsed = datetime.fromisoformat(normalized) | ||
| if parsed.tzinfo is None: | ||
| return parsed.replace(tzinfo=timezone.utc) | ||
|
|
||
| return parsed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't follow what 'lazy exports' is supposed to mean. If obvious/easy, answer here. If shameful/controversial, answer in slack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not shameful. Here "lazy exports" means the top-level
airbytemodule keeps the existing public API names, but it no longer imports full-package modules until the specific name is accessed.Example:
import airbyte as abstays lightweight;ab.get_sourcethen importsairbyte.sources.utilon first access and caches the resolved function. This letsairbyte-slimimport the shared top-level package without immediately requiring full-only modules like caches, sources, destinations, CLI, MCP, DuckDB, SQLAlchemy, or CDK.Devin session