-
Notifications
You must be signed in to change notification settings - Fork 73
ci(mcp): trigger cloud-mcp deploy after PyPI publish #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
90e381d
2fabc84
8c3e7b7
bb0a5fb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,3 +79,39 @@ jobs: | |
| - name: Publish to PyPI | ||
| if: github.event_name == 'release' || (github.event_name == 'workflow_dispatch' && github.event.inputs.publish == 'true') | ||
| uses: pypa/gh-action-pypi-publish@v1.13.0 | ||
|
|
||
| deploy_cloud_mcp: | ||
| name: Deploy Cloud MCP | ||
| needs: publish_to_pypi | ||
| if: github.event_name == 'release' | ||
| runs-on: ubuntu-latest | ||
| permissions: {} | ||
| steps: | ||
| - name: Wait for PyPI availability | ||
| run: sleep 120 | ||
|
|
||
| - name: Trigger cloud-mcp production deploy | ||
| uses: peter-evans/repository-dispatch@ff45666b9427631e3450c54a1bcbee4d9ff4d7c0 # v3 | ||
| with: | ||
| token: ${{ secrets.GITHUB_CI_WORKFLOW_TRIGGER_PAT }} | ||
| repository: airbytehq/airbyte-ops-mcp | ||
| event-type: deploy-cloud-mcp | ||
| client-payload: '{"mcp-server": "cloud-mcp"}' | ||
|
Comment on lines
+90
to
+99
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win Could we gate the dispatch on actual PyPI availability instead of a fixed 120s sleep, wdyt? This still races PyPI propagation. If the new Also applies to: 108-117 🤖 Prompt for AI Agents
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The 2-minute fixed wait was an explicit design choice by the maintainer. A polling loop would add complexity (need to extract the version, handle PyPI API rate limits, determine timeout/retry logic) for marginal benefit — PyPI propagation almost always completes well within 2 minutes, and even if it doesn't, the downstream If we want to tighten this in the future, it could be a follow-up improvement. |
||
|
|
||
| deploy_cloud_mcp_preview: | ||
| name: Deploy Cloud MCP (Preview) | ||
| needs: publish_to_pypi | ||
| if: github.event_name == 'workflow_dispatch' && github.event.inputs.publish == 'true' | ||
| runs-on: ubuntu-latest | ||
| permissions: {} | ||
| steps: | ||
| - name: Wait for PyPI availability | ||
| run: sleep 120 | ||
|
|
||
| - name: Trigger cloud-mcp preview deploy | ||
| uses: peter-evans/repository-dispatch@ff45666b9427631e3450c54a1bcbee4d9ff4d7c0 # v3 | ||
| with: | ||
| token: ${{ secrets.GITHUB_CI_WORKFLOW_TRIGGER_PAT }} | ||
| repository: airbytehq/airbyte-ops-mcp | ||
| event-type: deploy-cloud-mcp | ||
| client-payload: '{"mcp-server": "cloud-mcp", "preview": "true"}' | ||
Uh oh!
There was an error while loading. Please reload this page.