Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build(typing): migrate from pyrefly to ty for type checking #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
build(typing): migrate from pyrefly to ty for type checking #1054
Changes from all commits
20fe043417968ffabaf2672f4652File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable Error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Type-checker lint test will always fail because the tool it invokes was removed from dependencies
The type-checker dependency is replaced (
"ty>=0.0.56"atpyproject.toml:62) without updating the test that invokes the old tool (tests/lint_tests/test_mypy.py:13), so runningpytest tests/lint_tests/will always fail with a missing-command error.Impact: The lint test suite is broken and will fail in CI or local runs.
Incomplete pyrefly-to-ty migration leaves test calling removed tool
The PR removes
pyreflyfrom dev dependencies and replaces it withtyeverywhere in the source code and CI workflow. However,tests/lint_tests/test_mypy.py:12-13still runs:Since
pyreflyis no longer in the dependency group,uv run pyrefly checkwill fail (command not found), causing the test assertion attests/lint_tests/test_mypy.py:19to always fail.The fix should update this test to call
["uv", "run", "ty", "check"]and update the error messages accordingly.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 417968f — updated the test to call
uv run ty checkand renamed the function totest_type_checking.This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.