chore(lint): enable A003 rule (no builtin shadowing in classes) by aaronsteers · Pull Request #1055 · airbytehq/PyAirbyte

Aaron ("AJ") Steers (aaronsteers) · 2026-07-06T03:39:02Z

Summary

Un-ignore A003 which prevents class attributes from shadowing Python builtins (e.g. type, id, list). The codebase already has 0 violations — this just prevents future regressions.

No PR B (code compliance) needed since the codebase already complies.

Part of a set of 10 atomic proposals to increase ruff lint coverage in PyAirbyte.

Link to Devin session: https://app.devin.ai/sessions/6ae2048fc77a4f278aee3dd022384f4a
Requested by: Aaron ("AJ") Steers (@aaronsteers)

Summary by CodeRabbit

Chores
- Updated code quality checks to flag a previously excluded rule again, making linting stricter for future changes.

Un-ignore A003 which prevents class attributes from shadowing Python builtins (e.g. `type`, `id`, `list`). The codebase already has 0 violations, so this just prevents future regressions. Co-Authored-By: AJ Steers <aj@airbyte.io>

devin-ai-integration · 2026-07-06T03:39:05Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment, CI, and merge conflict monitoring

github-actions · 2026-07-06T03:39:18Z

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This PyAirbyte Version

You can test this version of PyAirbyte using the following:

# Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1783309098-ruff-enable-a003' pyairbyte --help

# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1783309098-ruff-enable-a003'

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

/fix-pr - Fixes most formatting and linting issues
/uv-lock - Updates uv.lock file
/test-pr - Runs tests with the updated PyAirbyte
/prerelease - Builds and publishes a prerelease version to PyPI

📚 Show Repo Guidance

Helpful Resources

Community Support

Questions? Join the #pyairbyte channel in our Slack workspace.

📝 Edit this welcome message.

coderabbitai · 2026-07-06T03:41:55Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f9f979f1-a566-4d07-9ef3-63efe0903747

📥 Commits

Reviewing files that changed from the base of the PR and between 15ca9ab and 4c23c33.

📒 Files selected for processing (1)

.ruff.toml

📝 Walkthrough

Walkthrough

The .ruff.toml configuration file was modified to comment out the A003 rule in the lint.ignore list, changing Ruff's behavior from suppressing A003 violations to actively reporting them.

Changes

Lint Configuration Update

Layer / File(s)	Summary
Enable A003 rule enforcement `.ruff.toml`	The `A003` rule entry is commented out in the `lint.ignore` list, so Ruff will now flag `A003` violations instead of suppressing them.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Related issues: None found in the provided context — was there a ticket tracking this rule change, wdyt?

Related PRs: None identified in the provided context.

Suggested labels: lint, config

Suggested reviewers: Given this is a small config tweak, a quick look from whoever owns the lint config setup should suffice, wdyt?

Poem:
A rabbit hopped through config's field,
One rule uncommented, once concealed,
A003 now stands revealed and bright,
Ruff will catch it, day or night,
A tiny change, but done just right! 🐇

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately summarizes enabling Ruff A003 to catch builtin shadowing in classes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch devin/1783309098-ruff-enable-a003

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-code-quality · 2026-07-06T03:46:29Z

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest-fast

The overall coverage in the devin/1783309098-ruf... branch is 67%. The coverage in the main branch is 65%.

Show a code coverage summary of the most impacted files.

File	main `d9f652f`	devin/1783309098-ruf... `4c23c33`	+/-
`airbyte/_util/api_util.py`	36%	37%	+1%
`airbyte/registry.py`	70%	72%	+2%
`airbyte/mcp/_tool_utils.py`	72%	77%	+5%
`airbyte/mcp/int...c_history_ui.py`	0%	36%	+36%
`airbyte/mcp/int...hared_models.py`	0%	81%	+81%
`airbyte/cloud/models.py`	0%	91%	+91%
`airbyte/mcp/int..._registry_ui.py`	0%	92%	+92%
`airbyte/mcp/int...nc_status_ui.py`	0%	97%	+97%
`airbyte/mcp/int...ive/__init__.py`	0%	100%	+100%
`airbyte/mcp/int...tive/_prefab.py`	0%	100%	+100%

Python / code-coverage/pytest-no-creds

The overall coverage in the devin/1783309098-ruf... branch is 67%. The coverage in the main branch is 65%.

Show a code coverage summary of the most impacted files.

File	main `d9f652f`	devin/1783309098-ruf... `4c23c33`	+/-
`airbyte/_util/api_util.py`	36%	37%	+1%
`airbyte/registry.py`	70%	72%	+2%
`airbyte/mcp/_tool_utils.py`	72%	77%	+5%
`airbyte/mcp/int...c_history_ui.py`	0%	36%	+36%
`airbyte/mcp/int...hared_models.py`	0%	81%	+81%
`airbyte/cloud/models.py`	0%	91%	+91%
`airbyte/mcp/int..._registry_ui.py`	0%	92%	+92%
`airbyte/mcp/int...nc_status_ui.py`	0%	97%	+97%
`airbyte/mcp/int...ive/__init__.py`	0%	100%	+100%
`airbyte/mcp/int...tive/_prefab.py`	0%	100%	+100%

Python / code-coverage/pytest

The overall coverage in the devin/1783309098-ruf... branch is 72%. The coverage in the main branch is 71%.

Show a code coverage summary of the most impacted files.

File	main `d9f652f`	devin/1783309098-ruf... `4c23c33`	+/-
`airbyte/registry.py`	70%	72%	+2%
`airbyte/mcp/_tool_utils.py`	72%	77%	+5%
`airbyte/mcp/server.py`	69%	76%	+7%
`airbyte/mcp/int...c_history_ui.py`	0%	36%	+36%
`airbyte/mcp/int...hared_models.py`	0%	81%	+81%
`airbyte/mcp/int..._registry_ui.py`	0%	92%	+92%
`airbyte/cloud/models.py`	0%	93%	+93%
`airbyte/mcp/int...nc_status_ui.py`	0%	97%	+97%
`airbyte/mcp/int...ive/__init__.py`	0%	100%	+100%
`airbyte/mcp/int...tive/_prefab.py`	0%	100%	+100%

_{Updated July 06, 2026 04:04 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.}

devin-ai-integration · 2026-07-06T03:59:54Z

Closing — will consolidate A003 into a bulk PR with other zero-violation rules.

Aaron ("AJ") Steers (aaronsteers) self-assigned this Jul 6, 2026

coderabbitai Bot approved these changes Jul 6, 2026

View reviewed changes

devin-ai-integration Bot closed this Jul 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(lint): enable A003 rule (no builtin shadowing in classes)#1055

chore(lint): enable A003 rule (no builtin shadowing in classes)#1055
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit into
mainfrom
devin/1783309098-ruff-enable-a003

Aaron ("AJ") Steers (aaronsteers) commented Jul 6, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

devin-ai-integration Bot commented Jul 6, 2026

Uh oh!

github-actions Bot commented Jul 6, 2026

Testing This PyAirbyte Version

PR Slash Commands

Helpful Resources

Community Support

Uh oh!

coderabbitai Bot commented Jul 6, 2026

Walkthrough

Changes

Uh oh!

github-code-quality Bot commented Jul 6, 2026 •

edited

Loading

Uh oh!

devin-ai-integration Bot commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Aaron ("AJ") Steers (aaronsteers) commented Jul 6, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

devin-ai-integration Bot commented Jul 6, 2026

🤖 Devin AI Engineer

Uh oh!

github-actions Bot commented Jul 6, 2026

👋 Greetings, Airbyte Team Member!

Testing This PyAirbyte Version

PR Slash Commands

Helpful Resources

Community Support

Uh oh!

coderabbitai Bot commented Jul 6, 2026

Walkthrough

Changes

Uh oh!

github-code-quality Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Overview

Python / code-coverage/pytest-fast

Python / code-coverage/pytest-no-creds

Python / code-coverage/pytest

Uh oh!

devin-ai-integration Bot commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Aaron ("AJ") Steers (aaronsteers) commented Jul 6, 2026 •

edited by coderabbitai Bot

Loading

github-code-quality Bot commented Jul 6, 2026 •

edited

Loading