chore(lint): enable A003, PLW0108 rules (zero-violation easy wins)#1058
chore(lint): enable A003, PLW0108 rules (zero-violation easy wins)#1058Aaron ("AJ") Steers (aaronsteers) wants to merge 4 commits into
Conversation
Un-ignore A003 (no builtin shadowing in classes) and PLW0108 (no unnecessary lambdas). Both have 0 existing violations, so this is config-only with no code changes needed. Co-Authored-By: AJ Steers <aj@airbyte.io>
Auto-fix stale noqa comments that suppress rules not triggered on those lines. These accumulate as code changes and become misleading. Co-Authored-By: AJ Steers <aj@airbyte.io>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Warning Review limit reached
Next review available in: 7 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1783311246-ruff-easy-wins' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1783311246-ruff-easy-wins'PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesCommunity SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
…ix)" This reverts commit e03b9ac.
Per review feedback: remove lines from ignore entirely instead of commenting them out. Both rules are already selected via their parent categories (A and PL). Co-Authored-By: AJ Steers <aj@airbyte.io>
Code Coverage OverviewLanguages: Python Python / code-coverage/pytest-fastThe overall coverage in the branch is 67%. The coverage in the branch is 65%. Show a code coverage summary of the most impacted files.
Python / code-coverage/pytest-no-credsThe overall coverage in the branch is 67%. The coverage in the branch is 65%. Show a code coverage summary of the most impacted files.
Python / code-coverage/pytestThe overall coverage in the branch is 72%. The coverage in the branch is 71%. Show a code coverage summary of the most impacted files.
Updated |
Summary
Remove
A003andPLW0108from the ignore list. Both rules are already selected via their parent categories (AandPL), so removing the ignores enables enforcement.A003: Prevents class attributes from shadowing Python builtins liketype,id,listPLW0108: Flags unnecessary lambdas likelambda x: fn(x)which should just befnBoth rules have zero existing violations — this is a config-only change with no code impact.
Link to Devin session: https://app.devin.ai/sessions/6ae2048fc77a4f278aee3dd022384f4a
Requested by: Aaron ("AJ") Steers (@aaronsteers)