chore(lint): enable PERF203 rule (no try-except in loops) by aaronsteers · Pull Request #1059 · airbytehq/PyAirbyte

Aaron ("AJ") Steers (aaronsteers) · 2026-07-06T04:19:29Z

Summary

Un-ignore PERF203 which flags try/except blocks inside for/while loops. Exception handling in loops has a measurable performance cost and often indicates code that should use guard statements instead.

70 existing violations. PR B (stacked on this branch) will add noqa directives for existing violations.

# .ruff.toml ignore list
-    "PERF203", # exception handling in loop
+    # "PERF203", # exception handling in loop (now enforced)

Link to Devin session: https://app.devin.ai/sessions/6ae2048fc77a4f278aee3dd022384f4a
Requested by: Aaron ("AJ") Steers (@aaronsteers)

Un-ignore PERF203 which flags try/except blocks inside for/while loops. Moving exception handling outside loops improves performance and aligns with the org's guard-statement-over-try-except standard. 70 existing violations need compliance fixes. Co-Authored-By: AJ Steers <aj@airbyte.io>

devin-ai-integration · 2026-07-06T04:19:32Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment, CI, and merge conflict monitoring

coderabbitai · 2026-07-06T04:19:39Z

Warning

Review limit reached

@devin-ai-integration[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 8 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 15f74985-b40d-4dd4-b86c-66ab43cc78c7

📥 Commits

Reviewing files that changed from the base of the PR and between 15ca9ab and 776f3d2.

📒 Files selected for processing (1)

.ruff.toml

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch devin/1783311542-ruff-enable-perf203

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-06T04:19:47Z

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This PyAirbyte Version

You can test this version of PyAirbyte using the following:

# Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1783311542-ruff-enable-perf203' pyairbyte --help

# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1783311542-ruff-enable-perf203'

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

/fix-pr - Fixes most formatting and linting issues
/uv-lock - Updates uv.lock file
/test-pr - Runs tests with the updated PyAirbyte
/prerelease - Builds and publishes a prerelease version to PyPI

📚 Show Repo Guidance

Helpful Resources

Community Support

Questions? Join the #pyairbyte channel in our Slack workspace.

📝 Edit this welcome message.

Aaron ("AJ") Steers (aaronsteers) · 2026-07-06T04:20:56Z

    "NPY",     # NumPy-specific rules
    "PIE790",  # Allow unnecssary 'pass' (sometimes useful for readability)
-    "PERF203", # exception handling in loop
+    # "PERF203", # exception handling in loop (now enforced)


Move to explicit 'select' list rather than commenting-out the ignore.

☑️ Resolved. Will remove from ignore entirely and add explicit \"PERF203\" to the select list. Applying this pattern to all PRs in the series.

Devin session

Per review feedback: remove from ignore entirely instead of commenting out. PERF203 is already selected via the PERF category. Co-Authored-By: AJ Steers <aj@airbyte.io>

github-code-quality · 2026-07-06T04:29:46Z

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest-fast

The overall coverage in the devin/1783311542-ruf... branch is 67%. The coverage in the main branch is 65%.

Show a code coverage summary of the most impacted files.

File	main `d9f652f`	devin/1783311542-ruf... `776f3d2`	+/-
`airbyte/_util/api_util.py`	36%	37%	+1%
`airbyte/registry.py`	70%	72%	+2%
`airbyte/mcp/_tool_utils.py`	72%	77%	+5%
`airbyte/mcp/int...c_history_ui.py`	0%	36%	+36%
`airbyte/mcp/int...hared_models.py`	0%	81%	+81%
`airbyte/cloud/models.py`	0%	91%	+91%
`airbyte/mcp/int..._registry_ui.py`	0%	92%	+92%
`airbyte/mcp/int...nc_status_ui.py`	0%	97%	+97%
`airbyte/mcp/int...ive/__init__.py`	0%	100%	+100%
`airbyte/mcp/int...tive/_prefab.py`	0%	100%	+100%

Python / code-coverage/pytest-no-creds

The overall coverage in the devin/1783311542-ruf... branch is 67%. The coverage in the main branch is 65%.

Show a code coverage summary of the most impacted files.

File	main `d9f652f`	devin/1783311542-ruf... `776f3d2`	+/-
`airbyte/_util/api_util.py`	36%	37%	+1%
`airbyte/registry.py`	70%	72%	+2%
`airbyte/mcp/_tool_utils.py`	72%	77%	+5%
`airbyte/mcp/int...c_history_ui.py`	0%	36%	+36%
`airbyte/mcp/int...hared_models.py`	0%	81%	+81%
`airbyte/cloud/models.py`	0%	91%	+91%
`airbyte/mcp/int..._registry_ui.py`	0%	92%	+92%
`airbyte/mcp/int...nc_status_ui.py`	0%	97%	+97%
`airbyte/mcp/int...ive/__init__.py`	0%	100%	+100%
`airbyte/mcp/int...tive/_prefab.py`	0%	100%	+100%

Python / code-coverage/pytest

The overall coverage in the devin/1783311542-ruf... branch is 72%. The coverage in the main branch is 71%.

Show a code coverage summary of the most impacted files.

File	main `d9f652f`	devin/1783311542-ruf... `776f3d2`	+/-
`airbyte/registry.py`	70%	72%	+2%
`airbyte/mcp/_tool_utils.py`	72%	77%	+5%
`airbyte/mcp/server.py`	69%	76%	+7%
`airbyte/mcp/int...c_history_ui.py`	0%	36%	+36%
`airbyte/mcp/int...hared_models.py`	0%	81%	+81%
`airbyte/mcp/int..._registry_ui.py`	0%	92%	+92%
`airbyte/cloud/models.py`	0%	93%	+93%
`airbyte/mcp/int...nc_status_ui.py`	0%	97%	+97%
`airbyte/mcp/int...ive/__init__.py`	0%	100%	+100%
`airbyte/mcp/int...tive/_prefab.py`	0%	100%	+100%

_{Updated July 06, 2026 04:47 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.}

Aaron ("AJ") Steers (aaronsteers) self-assigned this Jul 6, 2026

Aaron ("AJ") Steers (aaronsteers) mentioned this pull request Jul 6, 2026

style(lint): add PERF203 noqa directives for existing violations #1060

Draft

Aaron ("AJ") Steers (aaronsteers) commented Jul 6, 2026

View reviewed changes

fix(lint): remove PERF203 from ignore list (already selected via PERF)

776f3d2

Per review feedback: remove from ignore entirely instead of commenting out. PERF203 is already selected via the PERF category. Co-Authored-By: AJ Steers <aj@airbyte.io>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(lint): enable PERF203 rule (no try-except in loops)#1059

chore(lint): enable PERF203 rule (no try-except in loops)#1059
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
mainfrom
devin/1783311542-ruff-enable-perf203

Aaron ("AJ") Steers (aaronsteers) commented Jul 6, 2026

Uh oh!

devin-ai-integration Bot commented Jul 6, 2026

Uh oh!

coderabbitai Bot commented Jul 6, 2026 •

edited

Loading

Review limit reached

Uh oh!

github-actions Bot commented Jul 6, 2026

Testing This PyAirbyte Version

PR Slash Commands

Helpful Resources

Community Support

Uh oh!

Aaron ("AJ") Steers (aaronsteers) Jul 6, 2026

Uh oh!

devin-ai-integration Bot Jul 6, 2026

Uh oh!

github-code-quality Bot commented Jul 6, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Aaron ("AJ") Steers (aaronsteers) commented Jul 6, 2026

Summary

Uh oh!

devin-ai-integration Bot commented Jul 6, 2026

🤖 Devin AI Engineer

Uh oh!

coderabbitai Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

github-actions Bot commented Jul 6, 2026

👋 Greetings, Airbyte Team Member!

Testing This PyAirbyte Version

PR Slash Commands

Helpful Resources

Community Support

Uh oh!

Aaron ("AJ") Steers (aaronsteers) Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-code-quality Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Overview

Python / code-coverage/pytest-fast

Python / code-coverage/pytest-no-creds

Python / code-coverage/pytest

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented Jul 6, 2026 •

edited

Loading

github-code-quality Bot commented Jul 6, 2026 •

edited

Loading