Add Notepad++#103
Conversation
troyaf
left a comment
troyaf
left a comment
There was a problem hiding this comment.
Please run the build in your pipeline so I can verify the output.
|
Please see the run now at https://github.com/lgolstongov/shipyard/actions/runs/20865204981 |
|
Re-ran to fix verified commit: https://github.com/lgolstongov/shipyard/actions/runs/20866505054 |
|
|
||
| function global:Test-PwrPackageInstall { | ||
| Airpower exec 'file:///\pkg' { | ||
| notepad++ --help |
There was a problem hiding this comment.
This doesn't print in the action output. Please verify.
There was a problem hiding this comment.
Notepad++ does not have a built-in command-line argument to display its version and exit 0 immediately.
Author might consider
if (-not (Test-Path 'notepad++.exe')) { return -1 }or
if ([string]::IsNullOrWhiteSpace((Get-Item 'notepad++.exe').VersionInfo.FileVersion)) { return -1 }There was a problem hiding this comment.
I did not know how best to handle the version not returning like the other scripts, but have tried a different approach now. The workflow is now run at https://github.com/lgolstongov/shipyard/actions/runs/23810371752/job/69395458263. Please let me know if it is okay.
3 participants
Closes #73