Open
Conversation
Collaborator
There was a problem hiding this comment.
This should be in agents/opencode/human_readable_trace.py
Collaborator
There was a problem hiding this comment.
Can be removed.
This functionality is covered by scripts/parse_all_to_human_readable.sh
Collaborator
There was a problem hiding this comment.
Maybe we can revert this to non-zeroshot?
Collaborator
There was a problem hiding this comment.
Similarly, it seems that we can revert this to non-zeroshot
Comment on lines
119
to
121
| # Load baseline data | ||
| baseline_path = os.path.join(results_dir, "aggregated_baseline.csv") | ||
| baseline_path = os.path.join(results_dir, "aggregated_baseline_zeroshot.csv") | ||
| baseline_data, baseline_benchmarks = load_csv_as_dict(baseline_path) |
Comment on lines
39
to
41
| # Scan all directories | ||
| for subdir in results_path.glob('baseline/*'): | ||
| for subdir in results_path.glob('baseline_zeroshot/*'): | ||
| if subdir.is_dir(): |
Comment on lines
83
to
85
| if args.include_baseline: | ||
| baseline_path = os.path.join(results_dir, "aggregated_baseline.csv") | ||
| baseline_path = os.path.join(results_dir, "aggregated_baseline_zeroshot.csv") | ||
| header, rows = load_csv_rows(baseline_path) |
| fi | ||
|
|
||
| export HF_HOME_NEW="/home/ben/hf_cache" | ||
| source /etc/profile.d/modules.sh |
Collaborator
There was a problem hiding this comment.
Not necessary I think
Should be covered by the first lines:
if [ "${POST_TRAIN_BENCH_JOB_SCHEDULER}" = "htcondor_mpi-is" ]; then
source /etc/profile.d/modules.sh
fi
And will run into errors for non-mpi cluster
| executable = /bin/bash | ||
| arguments = src/run_task.sh $(eval) $(agent) $(model_to_train) $(Cluster) $(num_hours) $(agent_config) | ||
| environment = "OPENAI_API_KEY=$ENV(OPENAI_API_KEY) ANTHROPIC_API_KEY=$ENV(ANTHROPIC_API_KEY) GEMINI_API_KEY=$ENV(GEMINI_API_KEY) HOME=$ENV(HOME) POST_TRAIN_BENCH_RESULTS_DIR=$ENV(POST_TRAIN_BENCH_RESULTS_DIR) POST_TRAIN_BENCH_CONTAINERS_DIR=$ENV(POST_TRAIN_BENCH_CONTAINERS_DIR) POST_TRAIN_BENCH_CONTAINER_NAME=$ENV(POST_TRAIN_BENCH_CONTAINER_NAME) POST_TRAIN_BENCH_JOB_SCHEDULER=$ENV(POST_TRAIN_BENCH_JOB_SCHEDULER) POST_TRAIN_BENCH_EXPERIMENT_NAME=$ENV(POST_TRAIN_BENCH_EXPERIMENT_NAME) HF_HOME=$ENV(HF_HOME) POST_TRAIN_BENCH_PROMPT=$ENV(POST_TRAIN_BENCH_PROMPT)" | ||
| environment = "OPENAI_API_KEY=$ENV(OPENAI_API_KEY) ANTHROPIC_API_KEY=$ENV(ANTHROPIC_API_KEY) GEMINI_API_KEY=$ENV(GEMINI_API_KEY) OPENCODE_API_KEY=$ENV(OPENCODE_API_KEY) KIMI_API_KEY=$ENV(KIMI_API_KEY) DASHSCOPE_API_KEY=$ENV(DASHSCOPE_API_KEY) ZAI_API_KEY=$ENV(ZAI_API_KEY) HOME=$ENV(HOME) POST_TRAIN_BENCH_RESULTS_DIR=$ENV(POST_TRAIN_BENCH_RESULTS_DIR) POST_TRAIN_BENCH_CONTAINERS_DIR=$ENV(POST_TRAIN_BENCH_CONTAINERS_DIR) POST_TRAIN_BENCH_CONTAINER_NAME=$ENV(POST_TRAIN_BENCH_CONTAINER_NAME) POST_TRAIN_BENCH_JOB_SCHEDULER=$ENV(POST_TRAIN_BENCH_JOB_SCHEDULER) POST_TRAIN_BENCH_EXPERIMENT_NAME=$ENV(POST_TRAIN_BENCH_EXPERIMENT_NAME) HF_HOME=$ENV(HF_HOME) POST_TRAIN_BENCH_PROMPT=$ENV(POST_TRAIN_BENCH_PROMPT)" |
Collaborator
There was a problem hiding this comment.
Do you use KIMI_API_KEY?
-> otherwise we can remove this one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant main changes
Agent Implementation
Trace Parsing
Usage at the moment:
List of supported models for Zen are at https://opencode.ai/docs/zen/
Notes