forked from egraphs-good/egglog
-
Notifications
You must be signed in to change notification settings - Fork 0
Remove the serialization size bottleneck #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
2374094
Use Flexbuffer
FTRobbin dae76d2
Implement SizeReport
FTRobbin 156f463
Dig deeper into the size blowup
FTRobbin 92cc333
Serialize span into unit
FTRobbin c37fd3a
Add control for how much size information to output
FTRobbin a099964
Merge remote-tracking branch 'origin' into haobin-mining
FTRobbin 4234f79
Extract experiment runs
FTRobbin 9c85469
Tweak nightly frontent to display extract experiment results
FTRobbin 54533db
Show egraph size in size report
FTRobbin dcf81e5
Add include ser time option, add a speedup graph
FTRobbin 41a6fe8
Merge remote-tracking branch 'origin' into haobin-mining
FTRobbin 63d2be2
fmt
FTRobbin c54b1a2
Skip tests because containers are not yet supported
FTRobbin c15978f
Merge remote-tracking branch 'origin' into haobin-mining
FTRobbin 85dcdcf
Comment local dev setup
FTRobbin 1d46162
Output a csv file with serialization size data
FTRobbin a575829
fmt
FTRobbin 96ea226
Hacks
FTRobbin 53cb8f8
fmt
FTRobbin 78f79fb
More more evil hacks
FTRobbin 41742d6
Remove Easteregg from the list of experiments
FTRobbin 35fa1d9
Clean up evil hacks
FTRobbin a939da6
fmt
FTRobbin 9b6eaf1
Merge remote-tracking branch 'origin' into haobin-mining
FTRobbin 0e3ffb4
fmt
FTRobbin eeac398
Fix the rebuilding bug
FTRobbin 381b1ea
Added `stablize` to prevent stale rows in serialization
FTRobbin 22361fc
Typo
FTRobbin 04007f1
Addressing Noah's comments
FTRobbin 023d3e3
Addressing Anjali's comments
FTRobbin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we skip serializing the only field in this struct, is it better to skip serializing the FreeList where it's used in SubsetBuffer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that would be better. In fact, we can skip the whole
SubsetBuffer. But, it is used in many places, and the overhead is negligible.