forward hide_text through archive read path to PDFFile#129
Closed
ajslater wants to merge 1 commit into
Closed
Conversation
Adds ``hide_text: bool = False`` keyword to ``get_page_by_index``, ``get_pages``, ``get_page_by_filename``, ``_archive_readfile``, and ``Archive.read``. PDF archives forward it to ``PDFFile.read``; non-PDF archives accept the kwarg and silently ignore it (it has no meaning for image-pages-in-zip layouts). Requires comicbox-pdffile > 0.5.0 (the version that adds the ``hide_text`` knob to ``read_pdf`` / ``read_pixmap`` / ``read``). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plumbs the new
hide_textknob from comicbox-pdffile (ajslater/pdffile#19) through the comicbox read path so callers — codex in particular — can request invisible-text rendering on PDF pages without bypassing comicbox's archive abstraction.get_page_by_index,get_pages,get_page_by_filenameaccepthide_text: bool = Falseand forward it._archive_readfile(inComicboxArchiveRead) andArchive.read(the dispatcher) accept it too.PDFFile.read(..., hide_text=...); non-PDF archive types accept the kwarg and silently ignore it (it has no meaning for image-pages-in-zip layouts).Requires
comicbox-pdffile > 0.5.0once that PR ships.Test plan
tests/test_pages.pycases: PDF hide_text changes the page (pixmap differs from baseline),hide_text=Falsematches the legacy default, non-PDF archive accepts and ignores the kwarg.🤖 Generated with Claude Code