-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add portfolio category rollup helper for dashboard summaries #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aking13
wants to merge
2
commits into
main
Choose a base branch
from
feat/category-rollup-helper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
86 changes: 86 additions & 0 deletions
86
src/main/java/io/ventureplatform/util/InvestmentRollup.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| package io.ventureplatform.util; | ||
|
|
||
| import java.util.Comparator; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Objects; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| /** | ||
| * Aggregates investment data across portfolio companies for dashboard rollups. | ||
| * | ||
| * <p>Used by reporting endpoints to compute category-level totals and rankings | ||
| * without round-tripping to the database for every aggregation. | ||
| */ | ||
| public final class InvestmentRollup { | ||
|
|
||
| private InvestmentRollup() { | ||
| // utility class | ||
| } | ||
|
|
||
| /** | ||
| * Sum the total investment amount for portfolio companies matching the | ||
| * given category. Companies whose {@code amount} is missing or null are | ||
| * treated as 0. Returns 0 if no matches. | ||
| */ | ||
| public static long totalInvestmentByCategory( | ||
| final List<Map<String, Object>> companies, final String category) { | ||
| long total = 0; | ||
| for (Map<String, Object> company : companies) { | ||
| if (Objects.equals(company.get("category"), category)) { | ||
| total += amountOrZero(company); | ||
| } | ||
| } | ||
| return total; | ||
| } | ||
|
|
||
| /** | ||
| * Find the top {@code topN} companies by investment amount in the given | ||
| * category, sorted descending. Companies with a missing or null amount are | ||
| * treated as 0. | ||
| * | ||
| * @throws IllegalArgumentException if {@code topN} is not positive | ||
| */ | ||
| public static List<Map<String, Object>> topByInvestment( | ||
| final List<Map<String, Object>> companies, | ||
| final String category, | ||
| final int topN) { | ||
|
ak684 marked this conversation as resolved.
|
||
| if (topN <= 0) { | ||
| throw new IllegalArgumentException("topN must be positive, got " + topN); | ||
| } | ||
| return companies.stream() | ||
| .filter(c -> Objects.equals(c.get("category"), category)) | ||
| .sorted(Comparator.comparingLong(InvestmentRollup::amountOrZero).reversed()) | ||
| .limit(topN) | ||
| .toList(); | ||
| } | ||
|
|
||
| /** | ||
| * Build a parameterized SQL filter clause of the form | ||
| * {@code category IN (?, ?, ?)} along with the bind values to pass to the | ||
| * driver. Callers must bind {@link CategoryFilter#params()} positionally; | ||
| * raw category strings are never inlined into the clause. | ||
| * | ||
| * @throws IllegalArgumentException if {@code categories} is null or empty | ||
| */ | ||
| public static CategoryFilter buildCategoryFilter(final List<String> categories) { | ||
| if (categories == null || categories.isEmpty()) { | ||
| throw new IllegalArgumentException("categories must not be null or empty"); | ||
| } | ||
| String placeholders = categories.stream().map(c -> "?").collect(Collectors.joining(", ")); | ||
| return new CategoryFilter("category IN (" + placeholders + ")", List.copyOf(categories)); | ||
| } | ||
|
|
||
| private static long amountOrZero(final Map<String, Object> company) { | ||
| Object amount = company.get("amount"); | ||
| return amount instanceof Number n ? n.longValue() : 0L; | ||
| } | ||
|
|
||
| /** | ||
| * Parameterized SQL fragment paired with the bind values it expects. | ||
| * | ||
| * @param clause SQL fragment with {@code ?} placeholders | ||
| * @param params bind values, in the same order as the placeholders | ||
| */ | ||
| public record CategoryFilter(String clause, List<String> params) { } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.