Skip to content

[Fixes #76] Override previous request options in concurrent issues. #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NikosRig wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Fixes #76] Override previous request options in concurrent issues. #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/AktiveMerchant/Http/Adapter/cUrl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ protected function apply_options(RequestInterface $request)
);

$config = $this->map_config($request->getConfig());
$this->options = $this->options + $config + $default;
$this->options = array_replace($this->options, $config, $default);

curl_setopt_array($this->ch, $this->options);
}
Expand Down
25 changes: 24 additions & 1 deletion tests/AktiveMerchant/Http/Adapter/cUrlTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
namespace AktiveMerchant\Http\Adapter;

use AktiveMerchant\Mock\Request;
use PHPUnit_Framework_TestCase;

class cUrlTest extends \PHPUnit_Framework_TestCase
class cUrlTest extends PHPUnit_Framework_TestCase
{
public function testAdapterConfig()
{
Expand All @@ -26,4 +27,26 @@ public function testAdapterConfig()

$this->assertEquals(20, $options[CURLOPT_CONNECTTIMEOUT]);
}

/**
* @throws Exception
*/
public function testItShouldOverrideOptionsOnConcurrentRequests()
{
$request = new Request();
$adapter = new cUrl();

$request->setUrl('http://www.httpbin.org/get');
$adapter->sendRequest($request);

$concurrentRequestUrl = 'https://www.examples.com/';
$request->setUrl($concurrentRequestUrl);
$adapter->sendRequest($request);
$concurrentOptions = $adapter->getOptions();

$this->assertEquals(
$concurrentRequestUrl,
$concurrentOptions[10002]
);
}
}