Open
Conversation
roertbb
reviewed
Feb 25, 2021
| test.todo('test'); | ||
| import React from 'react'; | ||
| import { render, screen } from '@testing-library/react'; | ||
| // import userEvent from '@testing-library/user-event'; |
Collaborator
There was a problem hiding this comment.
if unused - can be removed? 😉
Collaborator
expect(screen.getByRole('link')).toHaveAttribute('href', event.url);should do the job ;) |
roertbb
reviewed
Feb 25, 2021
| import { render, screen } from '@testing-library/react'; | ||
| // import userEvent from '@testing-library/user-event'; | ||
| import moment from 'moment'; | ||
| import 'moment/locale/en-gb'; |
Collaborator
There was a problem hiding this comment.
we don't need that actually here actually, it would be worth it to do that in setupTests to make it work for all tests
roertbb
reviewed
Feb 25, 2021
| import ListingItem from './listing-item'; | ||
|
|
||
| const event = { | ||
| date: '25.03.2021', |
Collaborator
There was a problem hiding this comment.
new Date(2021, 2, 25) would be more suitable to match events coming from events.js
Collaborator
|
Ping me on priv next time pls , it can increase the probability I'll 👀 such things sooner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented new tests. I tried to write test whether a element is rendering with correct href attributte value also but I'm afraid that without custom queries it is impossible. Am I wrong?