Draft
Conversation
akaihola
force-pushed
the
mac-newline-tests
branch
2 times, most recently
from
a8dae2d to
c3d8197
Compare
akaihola
added
the
maybe invalid?
akaihola
force-pushed
the
mac-newline-tests
branch
5 times, most recently
from
6f45663 to
cf22df4
Compare
akaihola
force-pushed
the
mac-newline-tests
branch
from
cf22df4 to
a57dfbd
Compare
Owner
Author
|
Postponing to version 1.7.1 since we haven't heard any requests about this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #377 (comment)
In that comment, @jedie suggested to add tests for macos-style newlines (
"\r"). I did that, and started getting a lot of test failures.I haven't yet heard of any complaints from macos users about newlines being treated wrong. I wonder if
"\r"is ever encountered in real life in Python projects.