Custom Watcher#36
Open
kkolstad-trov wants to merge 4 commits intoakoenig:masterfrom
kkolstad:custom-watcher
Open
Custom Watcher#36kkolstad-trov wants to merge 4 commits intoakoenig:masterfrom kkolstad:custom-watcher
kkolstad-trov wants to merge 4 commits intoakoenig:masterfrom
kkolstad:custom-watcher
Conversation
|
I'm running into a similar need +1 this PR |
|
I'm having a similar issue with circular dependency. The deck can still render, but only after a long and painful list of
The deep watch over here is makes circular dependency not work. While in my company usecase, I changed it to I could create a PR to make this change but I'm unsure if this's the intended usecase. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My company is using angular-deckgrid and we ran into issues with the watcher being too complex because we have circular references in our objects. This PR allows you to supply a function which is used to create a string that will be used as the watch expression.