Thermal manager fix message#29
Open
VadymYashchenko wants to merge 5 commits into
Open
Conversation
Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>
Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>
msosyak
reviewed
Dec 24, 2021
msosyak
reviewed
Dec 24, 2021
akokhan
reviewed
Dec 24, 2021
akokhan
reviewed
Dec 24, 2021
| self.work() | ||
| self.__timer = Timer(self.__polling_thermal_time, self.start) | ||
| self.__timer.start() | ||
| if self.__running == True: |
Owner
There was a problem hiding this comment.
should not be if not self.__running: ?
Author
There was a problem hiding this comment.
In this case it will be simple return without any action
Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>
akokhan
reviewed
Jan 14, 2022
|
|
||
| # Thermal -> ThermalBase -> DeviceBase | ||
| class Thermal(ThermalBase): | ||
| _thresholds = { |
Owner
There was a problem hiding this comment.
Will it work for Montara/Maveriks ?
Author
There was a problem hiding this comment.
I am not sure. For final solution about Montara to need testing and maybe additional records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
####Why I did it
I fixed LGTM message for Unnecessary delete statement in function and
Dec 23 10:30:37.956959 sonic INFO telemetry#supervisord 2021-12-23 10:30:37,956 INFO exited: dependent-startup (exit status 0; expected) Dec 23 10:31:05.949734 sonic WARNING pmon#thermalctld: High temperature warning: psu_driver-i2c-7-5a:psu1-temp1 current temperature 27.125C, high threshold -999.9C Dec 23 10:31:41.436897 sonic WARNING pmon#thermalctld: High temperature warning: psu_driver-i2c-7-5a:psu1-temp2 current temperature 38.0C, high threshold -999.9C
####How I did it
I reworked ThermalManager and Thermal classes
####How to verify it
platform_tests/api/test_chassis.py; platform_tests/api/test_thermal.py; acl/test_acl.py;
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)