fix: propagate mutable list replacements - #340
Merged
Merged
Conversation
Lower native mutable list references as pointers to their slice descriptors so growth and whole-list replacement remain visible to callers. Preserve exact Go slice ABIs at foreign boundaries and reject descriptor-rebinding operations there. Fixes #339
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
mut [T]parameters previously copied Go slice descriptors, sopush,prepend, and whole-list assignment silently failed to update the caller.What's changed
[]T.Validation
cd compiler && go test ./... -count=1gopls checkon all changed Go files; only pre-existing redundant-break hints remain.git diff --check