fix(checker): reject private types in public APIs - #342
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The checker previously accepted public APIs containing private types. Generated Go then failed when another module needed to name the corresponding unexported Go type, so
ard checkandard builddisagreed.Migration
Make leaked types public or keep them entirely within private declarations. Dram and Maestro have already been updated to comply with this rule.
Validation
cd compiler && go test ./... -count=1cd website && npm run buildgopls checkon touched Go files; only pre-existing redundant-break hintsgit diff --checkFixes #337