Skip to content

feat(shell): add modern bash and fix gsync compatibility#34

Merged
akornmeier merged 1 commit into
mainfrom
fix/gsync-script
Dec 12, 2025
Merged

feat(shell): add modern bash and fix gsync compatibility#34
akornmeier merged 1 commit into
mainfrom
fix/gsync-script

Conversation

@akornmeier

Copy link
Copy Markdown
Owner
  • Add bash 5.x to Brewfile (macOS ships with 3.2)
  • Update gsync shebang to use env bash (respects PATH)
  • Enables mapfile and other modern bash features

  - Add bash 5.x to Brewfile (macOS ships with 3.2)
  - Update gsync shebang to use env bash (respects PATH)
  - Enables mapfile and other modern bash features
@akornmeier akornmeier self-assigned this Dec 12, 2025
Copilot AI review requested due to automatic review settings December 12, 2025 13:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes bash support in the dotfiles by adding bash 5.x to the Brewfile and updating the gsync script's shebang to use #!/usr/bin/env bash. The changes enable modern bash features like mapfile (used in gsync on line 21) on macOS, which ships with the outdated bash 3.2.

  • Add bash 5.x formula to Brewfile for modern bash features
  • Update gsync shebang to respect PATH and use Homebrew-installed bash
  • Add changeset documenting the patch update

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
Brewfile Adds bash 5.x formula with explanatory comment about macOS's outdated default
bin/gsync Updates shebang from #!/bin/bash to #!/usr/bin/env bash to use newer bash version in PATH
.changeset/tangy-views-try.md Documents the change as a patch update

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .changeset/tangy-views-try.md
@akornmeier akornmeier merged commit 2ece07e into main Dec 12, 2025
8 checks passed
@akornmeier akornmeier deleted the fix/gsync-script branch December 12, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants