feat(shell): add modern bash and fix gsync compatibility#34
Merged
Conversation
akornmeier
commented
Dec 12, 2025
Owner
- Add bash 5.x to Brewfile (macOS ships with 3.2)
- Update gsync shebang to use env bash (respects PATH)
- Enables mapfile and other modern bash features
- Add bash 5.x to Brewfile (macOS ships with 3.2) - Update gsync shebang to use env bash (respects PATH) - Enables mapfile and other modern bash features
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes bash support in the dotfiles by adding bash 5.x to the Brewfile and updating the gsync script's shebang to use #!/usr/bin/env bash. The changes enable modern bash features like mapfile (used in gsync on line 21) on macOS, which ships with the outdated bash 3.2.
- Add bash 5.x formula to Brewfile for modern bash features
- Update gsync shebang to respect PATH and use Homebrew-installed bash
- Add changeset documenting the patch update
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Brewfile | Adds bash 5.x formula with explanatory comment about macOS's outdated default |
| bin/gsync | Updates shebang from #!/bin/bash to #!/usr/bin/env bash to use newer bash version in PATH |
| .changeset/tangy-views-try.md | Documents the change as a patch update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.