docs: update copy promotion step behaviour and configuration - #6809
Open
robinlioret wants to merge 1 commit into
Open
docs: update copy promotion step behaviour and configuration#6809robinlioret wants to merge 1 commit into
robinlioret wants to merge 1 commit into
Conversation
Signed-off-by: Robin Lioret <robin.lioret@seqone.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fuskovic
requested changes
Aug 17, 2026
Comment on lines
+23
to
+26
| :::note | ||
| Symlinks encountered in the source are skipped, and `.git` directories are | ||
| always ignored, regardless of the `ignore` patterns. | ||
| ::: |
Member
There was a problem hiding this comment.
.git
directories are always ignored, regardless of theignore` patterns.
This isn't true. We even have a test for this that allows overriding default ignore rules that asserts a file in .git is included by using "!.git/"
https://github.com/akuity/kargo/blob/main/pkg/promotion/runner/builtin/file_copier_test.go#L302
So I would change that portion to something like:
".git is ignored by default but can be overridden by a user-supplied negation pattern"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the "copy" promotion step documentation:
Checklist
Eligibility
kind/proposal,needs discussion,needs research,maintainer only,area/security,size/large,size/x-large,size/xx-large).Quality
AI Use Disclosure
This PR was written:
Sign-Off
All commits:
git commit -s) (required)git commit -S) (encouraged)