Conversation
add upadate task that will only run when --ulkgr option passed
gibfahn
reviewed
Mar 2, 2018
bin/citgm-all.js
Outdated
| .option('last-know-good-release', { | ||
| alias: 'lkgr', | ||
| type: 'boolean', | ||
| description: 'Uses last know good release' |
bin/citgm-all.js
Outdated
| type: 'array', | ||
| description: 'Define which tags from the lookup to skip' | ||
| }) | ||
| .option('last-know-good-release', { |
bin/citgm.js
Outdated
| .option('last-known-good-release', { | ||
| alias: 'lkgr', | ||
| type: 'boolean', | ||
| description: 'Install last know good release' |
bin/citgm.js
Outdated
| .option('update-last-known-good-release', { | ||
| alias: 'ulkgr', | ||
| type: 'boolean', | ||
| description: 'Update last know good release' |
bin/citgm.js
Outdated
| type: 'boolean', | ||
| description: 'Install last know good release' | ||
| }) | ||
| .option('update-last-known-good-release', { |
|
|
||
| function update(context, next) { | ||
|
|
||
| if (context.options.ulkgr) { |
There was a problem hiding this comment.
Do you have a check to make sure the new module version isn't the same as the previous version? If they're the same there's no need to do all this.
Owner
Author
There was a problem hiding this comment.
I guess I should add an output saying that lookup is not being updated.
Owner
Author
There was a problem hiding this comment.
Just realised the link doesn't have the line number.
It is on line 16, and the info saying that lookup is already up to date is on line 36.
Run on darwin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added:
lkgrto the lookup (modules that passed on my mac).--lkgroption for citgm and citgm-all to run, which ranslkgrfrom the lookup, instead of defaulting to taking npm latest.--ulkgroption for citgm and citgm-all, to update lookupTODO: