docs(npu-operator): align installation page with 1.2.0 form + namespace layout#790
docs(npu-operator): align installation page with 1.2.0 form + namespace layout#790luohua13 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe NPU Operator docs clarify that operator-managed pods deploy into the operator namespace (default ChangesNPU Operator Installation Instructions
Release Notes
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/en/hardware_accelerator/npu/npu_operator/installation.mdx`:
- Line 105: The command example uses kubectl with the watch flag piped to grep
which causes buffering and prevents live updates; replace that pipeline with one
of the recommended alternatives: use a label selector with watch (e.g., use
kubectl get pod -l <label>=npu-driver -w if pods have a label), remove -w for a
one-time filtered listing (kubectl get pod | grep npu-driver), or use kubectl
wait to block until the npu-driver pods are Ready (kubectl wait
--for=condition=Ready pod -l <label>=npu-driver --timeout=600s); update the
example line that currently shows "kubectl -n npu-operator get pod -w | grep
npu-driver" to one of these alternatives and mention replacing <label> with the
actual pod label if applicable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 84ef781e-4410-423f-9241-402abb20a6ca
📒 Files selected for processing (1)
docs/en/hardware_accelerator/npu/npu_operator/installation.mdx
82e0dc5 to
47e94eb
Compare
…elease notes The 1.2.0 release of Alauda Build of NPU Operator changes the delivery model from cluster plugin (`Marketplace > Cluster Plugins`) to OLM operator (`Marketplace > OperatorHub`). Adapt the installation page and add a release notes page mirroring the per-product layout used by hami-docs. Installation page: - Rename Downloading/Uploading sections from "Cluster plugin" to "Packages" and enumerate both the operator package (npu-operator) and the cluster plugin packages (NFD required, Volcano optional). - Split installation into two subsections: NFD as a Cluster Plugin and NPU Operator via OperatorHub (Install dialog, namespace selector, deployment form). - Bump default Driver Version to 25.5.0 and rename the row to match the form label; add a note that all operator-managed pods land in the operator namespace and that Volcano components are absent. - Verification step 1 switches from the Cluster plugin page to the OperatorHub details page / Installed Operators view. - Verification step 2 watches the npu-driver pod in the operator namespace (was kube-system) with a note for non-default namespaces. - Installing Monitor: drop the obsolete manual ServiceMonitor snippet (which targeted the wrong namespaces); the operator now auto- installs npu-exporter-servicemonitor in its own namespace. Release notes: - v1.2.0 mapped to openFuyao npu-operator 1.2.0; headline is the cluster-plugin-to-operator delivery change (no in-place upgrade from v1.1.3) and the MindCluster/Ascend v7.3.0 stack bump. - Downstream bug fix highlighted is the npu-exporter ServiceMonitor not taking effect; plus the two community 1.1.1 -> 1.2.0 fixes. - v1.1.3 mapped to openFuyao npu-operator 1.1.1 (MindCluster v7.2.RC1, cluster-plugin delivery).
47e94eb to
aec4888
Compare
Deploying alauda-container-platform with
|
| Latest commit: |
aec4888
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://56806856.alauda-container-platform.pages.dev |
| Branch Preview URL: | https://docs-npu-operator-1-2-form-u-6gq3.alauda-container-platform.pages.dev |
Summary
Adapt the NPU Operator installation page to match the 1.2.0 release:
npu-operator). Previously they were spread acrosskube-system,mindx-dl,volcano-system, anddefault.Driver Version, default25.5.0, hidden whenDriveris disabled). The table row is renamed fromVersionand the default bumped accordingly.vccontroller/vcschedulertoggles are intentionally absent from the form; install the platform's Volcano cluster plugin separately when enabling ClusterD.kubectl waitfornpu-driverswitches fromkube-systemtonpu-operatorwith a note about non-default namespaces.npu-exporter-servicemonitorServiceMonitor in its own namespace, so the manual ServiceMonitor YAML (which created it inmonitoringnamespace selecting thenpu-exporternamespace) is removed.Verified against an actual 1.2.0 install on the
g1-c2-armcluster:kubectl get pod -A | grep -E "npu|ascend|noded|clusterd|exporter|mindio"— all innpu-operator.kubectl get servicemonitor -A | grep npu-exporter— auto-created innpu-operator.kubectl -n npu-operator get ds npu-driver -o jsonpath='{.spec.template.spec.containers[0].env}'—DRIVER_VERSION=25.5.0,HOST_DRIVER_SOURCE_PATH=/tmp/driver_pkg.Test plan
Summary by CodeRabbit
Documentation
Release Notes
New Features
Bug Fixes