Potential fix for code scanning alert no. 6: Clear text storage of sensitive information - #1
Merged
Merged
Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Albert Müller <p8bpg9zrw7@privaterelay.appleid.com>
albert-mueller
marked this pull request as ready for review
August 5, 2026 23:12
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (safeApiConfig.google) { | ||
| delete safeApiConfig.google.apiKey; | ||
| } | ||
| localStorage.setItem('translateApiConfig', JSON.stringify(safeApiConfig)); |
| if (safeApiConfig.google) { | ||
| delete safeApiConfig.google.apiKey; | ||
| } | ||
| localStorage.setItem('translateApiConfig', JSON.stringify(safeApiConfig)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/albert-mueller/albert-mueller.github.io/security/code-scanning/6
General fix: do not persist raw secrets in
localStorage. Prefer not storing them at all, or store only non-sensitive metadata (such as selected provider). If persistence is required, use secure server-side storage and keep only a reference token client-side.Best fix here without changing core translation functionality: keep runtime
setApiKey(...)behavior (so translation still works in current session), but sanitize what is written tolocalStorageby removingsecretKey/apiKeyfields beforeJSON.stringify(...). This addresses all listed variants tied to cleartext storage while preserving existing UX as much as possible (service selection can still persist).In
others/translate/translate.js, replace the directlocalStorage.setItem(... JSON.stringify(apiConfig))calls with a redacted copy that keeps only non-secret fields (service, and optionally non-secretappId). Also avoid callingsaveApiConfigwith secrets in the bottom section; pass empty strings there so no secret is persisted via that path.Suggested fixes powered by Copilot Autofix. Review carefully before merging.