Potential fix for code scanning alert no. 12: Clear text storage of sensitive information - #2
Merged
Merged
Conversation
…ensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Albert Müller <p8bpg9zrw7@privaterelay.appleid.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/albert-mueller/albert-mueller.github.io/security/code-scanning/12
To fix this without changing behavior, build a separate non-sensitive object for persistence instead of cloning
apiConfig(which contains secrets). Keep usingapiConfigfor in-memory runtime setup (setApiKeycalls), but constructsafeApiConfigdirectly from non-secret fields only (service, and optionally non-secret identifiers likeappId).Best change in
others/translate/translate.jsaround lines 285–296:JSON.parse(JSON.stringify(apiConfig))and all subsequentdeletestatements.secretKey/apiKey.localStorage.This addresses all six alert variants with one change by breaking taint flow from secret inputs to storage sink.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.