Potential fix for code scanning alert no. 11: Clear text storage of sensitive information - #3
Merged
Merged
Conversation
…ensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Albert Müller <p8bpg9zrw7@privaterelay.appleid.com>
albert-mueller
marked this pull request as ready for review
August 6, 2026 00:36
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…f sensitive information' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Albert Müller <p8bpg9zrw7@privaterelay.appleid.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/albert-mueller/albert-mueller.github.io/security/code-scanning/11
General fix: separate runtime secret handling from persisted config. Keep credentials only in memory (or session-only mechanisms if needed), and store only non-sensitive metadata in
localStorage(for example, selected service and non-secret IDs).Best fix here (without changing core behavior): in the API-config save flow (around lines 172–205), stop cloning/storing
apiConfigafter it has been tainted bysecretKey/apiKey; instead build a dedicatedpersistedConfigobject containing only safe fields and store that. This eliminates sensitive-data flow toJSON.stringify(...)and addresses all listed variants at once. No new imports/dependencies are needed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.