Potential fix for code scanning alert no. 10: Clear text storage of sensitive information - #5
Merged
Merged
Conversation
…ensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Albert Müller <p8bpg9zrw7@privaterelay.appleid.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/albert-mueller/albert-mueller.github.io/security/code-scanning/10
Best fix: stop storing API credentials in
localStorage. Keep non-sensitive settings persisted, but forceapiKey/apiSecretfields to empty strings before serialization in bothsaveSettings()andsaveApiConfig(service). This preserves app behavior for toggles and non-secret preferences while removing cleartext secret persistence. It also addresses all 5 alert variants in one change because every flagged source flows into these two storage writes.Edit only
others/translate/app.jsin:saveSettings()object construction (apiServices.baidu/youdao/googlesections): replace secret fields with''.saveApiConfig(service)switch cases forbaidu,youdao, andgoogle: replace persistedapiKey/apiSecretvalues with''while keepingenabledandappIdpersistence unchanged.No new imports/dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.