Potential fix for code scanning alert no. 5: DOM text reinterpreted as HTML - #6
Merged
Conversation
…s HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Albert Müller <p8bpg9zrw7@privaterelay.appleid.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/albert-mueller/albert-mueller.github.io/security/code-scanning/5
General fix: avoid injecting untrusted values into
innerHTML; instead build DOM nodes withcreateElementand assign untrusted text viatextContent(orinnerText). This preserves display behavior while preventing HTML interpretation.Best fix in
others/translate/app.jsaroundhandleFileUpload(lines ~2318 onward): replace the template-literalfileItem.innerHTML = ...block with explicit DOM construction. Keep static classes/structure the same, set:textContent(safe even if emoji/string),textContent(critical fix),textContent,Then append the built subtree to
fileItem. No new imports/dependencies needed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.