Skip to content

Conversation

@albertoivo
Copy link
Owner

Fixed a regression in PythonEditor where props passed to the Monaco Editor were being re-created on every render. This caused the editor to seemingly reload or flash (white blocks) and interfered with typing (losing focus or state).

Changes:

  • Memoized editorOptions using useMemo dependent on disabled.
  • Memoized handleChange using useCallback dependent on disabled and onChange.

Verified by:

  • Running all unit tests (npm run test:run) - all passed.
  • Running a Playwright script to verify the editor renders correctly in the game context.

PR created automatically by Jules for task 10397778889570175958 started by @albertoivo

The `PythonEditor` component was re-creating `editorOptions` and `handleChange` on every render, causing the Monaco Editor instance to re-initialize or lose focus, leading to visual glitches ("white blocks") and typing issues.

This commit wraps `editorOptions` in `useMemo` and `handleChange` in `useCallback` to ensure referential stability.

Co-authored-by: albertoivo <1276520+albertoivo@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 6f2a7cd):

https://pyexplorer-cd32d--pr140-fix-python-editor-re-1pxlk0i5.web.app

(expires Tue, 03 Feb 2026 15:19:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 916b4905e0cdc420f3368c8eb19b2f2e90c3be61

@albertoivo albertoivo merged commit 1bbbe34 into main Jan 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants