Open
Conversation
|
For me looks nice can you mege this too ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases bold fonts weren't rendered correctly. Especially for fonts that don't natively support bold text. See image below. For this demonstration I used the Tangerine Font from Google but it's not the only font that has the issue. Normally both lines should be the same length.
I solved the issue by adding a scaling transformation to those fonts that don't support bold text. Due to the fact that all fonts are slightly diffrent, I added the option
sto allow the user to set an individual scaling factor for their font.