PS-1145_databox indexer : fix missing rendition policy editable param#813
Open
moctardiouf wants to merge 1 commit into
Open
PS-1145_databox indexer : fix missing rendition policy editable param#813moctardiouf wants to merge 1 commit into
moctardiouf wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the databox indexer’s Phraseanet structure import to configure whether created rendition policies are “editable”, addressing a previously missing configuration parameter.
Changes:
- Extend the Phraseanet rendition configuration type to include
policyAssetEditable. - Ensure generated “missing renditions” configs include a default
policyAssetEditable: false. - Propagate
policyAssetEditableinto rendition policy creation via theeditablerequest field.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| databox/indexer/src/handlers/phraseanet/types.d.ts | Adds the policyAssetEditable?: boolean config field to rendition/subdef mapping types. |
| databox/indexer/src/handlers/phraseanet/StructureImporter.ts | Defaults and forwards policyAssetEditable into rendition policy creation (editable). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| useAsAnimatedThumbnail: boolean; | ||
| types: Record<string, PhraseanetSubdefStruct>; | ||
| policy: string | null; | ||
| policyAssetEditable: boolean | false; |
| subdefToRendition[settings['from']].push(name); | ||
| sdByName[name].types[sd.type] = sd; | ||
| sdByName[name].labels = sd.labels; // todo: check conflicts | ||
| sdByName[name].policyAssetEditable = rendition.policyAssetEditable ?? false; |
4rthem
requested changes
May 22, 2026
| rendition.useAsAnimatedThumbnail ?? false, | ||
| types: {} as Record<string, PhraseanetSubdefStruct>, | ||
| policy: rendition['policy'] ?? null, | ||
| policyAssetEditable: rendition['policyAssetEditable'] ?? false, |
Member
There was a problem hiding this comment.
Suggested change
| policyAssetEditable: rendition['policyAssetEditable'] ?? false, | |
| policyAssetEditable: rendition.policyAssetEditable ?? false, |
| useAsAnimatedThumbnail: boolean; | ||
| types: Record<string, PhraseanetSubdefStruct>; | ||
| policy: string | null; | ||
| policyAssetEditable: boolean | false; |
Member
There was a problem hiding this comment.
Suggested change
| policyAssetEditable: boolean | false; | |
| policyAssetEditable: boolean; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eter