fix(cloudflare/workers): drain pre-response handlers in serveWebRequest#178
Open
Mkassabov wants to merge 3 commits into
Open
fix(cloudflare/workers): drain pre-response handlers in serveWebRequest#178Mkassabov wants to merge 3 commits into
Mkassabov wants to merge 3 commits into
Conversation
`HttpMiddleware.cors()` (and any other middleware that registers a `preResponseHandler` for non-OPTIONS requests) was a no-op on real responses inside a `Cloudflare.Worker` — only OPTIONS preflights short-circuited with CORS headers. Run the handler through `HttpEffect.toHandled` so the registered pre-response handler chain fires before the response is converted to a web `Response`. Fixes #175
Contributor
|
Install the packages built from this commit: alchemy bun add alchemy@https://pkg.ing/alchemy/245e617@alchemy.run/better-auth bun add @alchemy.run/better-auth@https://pkg.ing/@alchemy.run/better-auth/245e617@alchemy.run/pr-package bun add @alchemy.run/pr-package@https://pkg.ing/@alchemy.run/pr-package/245e617 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpMiddleware.cors()(and any other middleware that registers apreResponseHandlerfor non-OPTIONS requests) was a no-op on real responses inside aCloudflare.Worker— only OPTIONS preflights short-circuited with CORS headers.serveWebRequestran the handler and converted the result straight to a webResponse, never draining the pre-response queue.Run the handler through effect's public
HttpEffect.toHandledso the registered pre-response handler chain fires before the response is converted.scopeTransferToStreamkeeps streaming bodies' scopes closing on stream end.Verified against the repro from #175: both
OPTIONSpreflight andGETnow carryAccess-Control-Allow-Origin.Fixes #175