fix(cloudflare): reconcile Worker preview subdomain state#285
Open
Dawsson wants to merge 2 commits into
Open
Conversation
Contributor
|
Please add regression tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Cloudflare Worker reconciliation enabled Preview URLs when it called the subdomain API, but it only diffed the observed
enabledflag. If a Worker hadenabled: trueandpreviewsEnabled: false, Alchemy skipped reconciliation.This matters for the Cloudflare state store bootstrap because it reads the auth secret through an edge-preview request. Cloudflare documents Preview URLs as a separate Worker setting, and the script subdomain API exposes
previews_enabledseparately fromenabled.Docs:
Solution
previewsEnabledwhen the desired workers.dev subdomain is enabled.enabled, matching the existing API call that sends onlyenabled: false.1031/Invalid Workers Preview configuration) while preview routing propagates.Validation
node_modules/.bin/oxfmt packages/alchemy/src/Cloudflare/Workers/Worker.ts packages/alchemy/src/Cloudflare/StateStore/State.tsnode_modules/.bin/tsc -b packages/alchemy/tsconfig.json --pretty falsegit diff --checkI also tried a live Worker regression test that manually disabled Preview URLs and redeployed, but it timed out waiting for initial workers.dev subdomain propagation before reaching the preview assertion. I left that test out because it would be flaky.