fix(sidecar): preserve Redacted values across RPC serialization#356
Open
schutzelaars wants to merge 1 commit into
Open
fix(sidecar): preserve Redacted values across RPC serialization#356schutzelaars wants to merge 1 commit into
schutzelaars wants to merge 1 commit into
Conversation
john-royal
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this while testing the Vite + Cloudflare Worker setup from #331 (
feat(cloudflare): vite dev). Onalchemy dev,Redactedvalues sent through the sidecar RPC arrive on the worker side as the literal string"<redacted>".Anything passing a
Redactedthrough a binding hits this. In my case, Hyperdrive'spassword:→
password authentication failed.JSON.stringifycallstoJSON()before the replacer, andRedacted.toJSON()returns"<redacted>", so this replacer in Sidecar/RpcHandler.ts never fires:Deserialize side already handles the
{ _tag: "Redacted", value }envelope.Fix
Pre-walk the args with
encodeRedactedbeforeJSON.stringify:RedactedtoJSON(Date, URL, …) soJSON.stringifykeeps using their custom shapeCovered by packages/alchemy/test/Sidecar/RpcHandler.test.ts: top-level
Redacted,Redactednested in an object, and aDatearg (exercises thetoJSONskip).