Support parsing time ranges - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
to_range()to parse date ranges such aslast 2 weeksorlast monthinto start and end timestamps. Start time is inclusive, end time exclusive.The implementation is quite simple for now, and limited to single recognized pattern rather than processing all recognized fragments. Latter would be plausible after we can identify the boundaries between two dates with some patterns - e.g.
between ... and ...With dates,
prev/lasthave been interchangeable used to mean the last full period of time, whilepastrefers to the period of time since current timetamp. E.g.last weekfor previous week whilepast weekfor past 7 days. This might not be so clear cut for ranges, so simply deferring implementingpastfor them.