fix: delimit parenthesized autolinks - #291
Open
PathGao wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@alecdotdev This is ready for review after #286. It adds a regression test and keeps the closing parenthesis plus adjacent text out of the bare URL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #290
Parenthesized bare URLs followed immediately by text are rendered as explicit Markdown links, so the closing parenthesis and following text stay outside the URL.
Includes a Rust regression test for the reported Speedtest URL.
Depends on #286 because upstream master currently has the toolbar-test regression fixed there; merge #286 first.