ci: sign and notarize macOS releases - #294
Closed
PathGao wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
@alecdotdev This is ready for review after #293 and #286. Before the next release, please add the six Apple secrets documented in the PR; without them the new macOS release gate will fail rather than publish another ad-hoc-signed bundle. |
Contributor
Author
|
Closing this PR in favor of #209. The workflow is correct only after an Apple Developer Program owner can provide a Developer ID Application certificate and notarization credentials; without them it would merely make every release fail. This is a release-ownership and credential prerequisite, not an application-code fix. |
Contributor
Author
|
Tracked in #209; see the issue for the required Apple-side setup and the interim workaround. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #209
The release workflow now imports a Developer ID Application certificate, passes the Apple notarization credentials to the macOS build, and fails instead of publishing another ad-hoc-signed macOS bundle when the identity is unavailable.
The release runbook documents the six required repository secrets. A maintainer must configure them before the next release.
Depends on #293, then #286, because this branch includes their CI-baseline fixes; merge in that order.