Fix split scroll sync triggered by typing - #304
Open
PathGao wants to merge 10 commits into
Open
Conversation
added 10 commits
July 31, 2026 11:07
Contributor
Author
|
@alecdotdev This is the next focused reliability fix in the existing chain. It removes the cursor-change trigger that made split panes jump during normal typing; it retains only actual editor-scroll synchronization. Please merge after #302, following the chain stated in the PR description. |
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #303
This removes the cursor-position listener from editor-to-preview scroll synchronization. A normal typing edit can move the cursor without representing an editor scroll, so it must not reposition the preview pane. Real editor scroll events continue to synchronize as before.
Regression coverage verifies that the synchronization effect listens to
onDidScrollChangeand notonDidChangeCursorPosition.Depends on #302. Merge order: #286 → #287 → #288 → #293 → #296 → #298 → #300 → #301 → #302 → this PR.
Validated with
npm ci,npm run check,npm test(135 tests), andcargo test(21 Rust tests).