Skip to content

Fix split scroll sync triggered by typing - #304

Open
PathGao wants to merge 10 commits into
alecdotdev:masterfrom
PathGao:fix/sync-only-on-editor-scroll
Open

Fix split scroll sync triggered by typing#304
PathGao wants to merge 10 commits into
alecdotdev:masterfrom
PathGao:fix/sync-only-on-editor-scroll

Conversation

@PathGao

@PathGao PathGao commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Fixes #303

This removes the cursor-position listener from editor-to-preview scroll synchronization. A normal typing edit can move the cursor without representing an editor scroll, so it must not reposition the preview pane. Real editor scroll events continue to synchronize as before.

Regression coverage verifies that the synchronization effect listens to onDidScrollChange and not onDidChangeCursorPosition.

Depends on #302. Merge order: #286#287#288#293#296#298#300#301#302 → this PR.

Validated with npm ci, npm run check, npm test (135 tests), and cargo test (21 Rust tests).

@PathGao

PathGao commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@alecdotdev This is the next focused reliability fix in the existing chain. It removes the cursor-change trigger that made split panes jump during normal typing; it retains only actual editor-scroll synchronization.

Please merge after #302, following the chain stated in the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split scroll sync repositions panes on every cursor move while typing

1 participant