Persist a validated preview width preference - #321
Open
PathGao wants to merge 19 commits into
Open
Conversation
added 19 commits
July 31, 2026 11:07
Contributor
Author
|
@alecdotdev This is the first focused #263 PR. It is stacked after #320 and its predecessors; please review in that order. The follow-up will wire this preference into Settings, preview layout, ToC geometry, and print behavior. |
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #263.
Adds one normalized, persistent preview-width preference: default 880 px, clamped to 640–1600 px, with invalid values recovering to the default. It deliberately does not reuse the Monaco wrapping-column setting.
The following UI/layout PR will consume this preference for preview width, Full mode, ToC geometry, and print-safe behavior.
This is stacked after #320 and its predecessors. Merge the predecessor chain first.
Validation
Post-Deploy Monitoring & Validation
No additional operational monitoring required: this commit only adds a local preference with deterministic validation. Owner: maintainer; validate persisted values, invalid localStorage recovery, and reset behavior in the follow-up UI PR.