Fix PDF width when exporting from split view - #329
Draft
PathGao wants to merge 26 commits into
Draft
Conversation
added 26 commits
July 31, 2026 11:07
Contributor
Author
|
@alecdotdev This is the next linear follow-up after #327. It fixes a confirmed macOS PDF regression specific to exporting while split view is active: the viewer pane retained its inline split flex ratio, so the PDF body used only part of the printable page. I verified the minimal print-only change in an isolated release bundle with a 20-section A4 export. Please merge it after #327; I left it as a draft until that dependency lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The viewer pane receives an inline
flexvalue in split view. The existing print CSS setwidth: 100%, but that does not override the flex-item sizing. PDF output from split view therefore used only the viewer's on-screen fraction of the page.Validation
npm cinpm run checknpm test(150 passed)cargo test(27 passed)Fixes #328.
Chain
Depends on #327. Please merge after #327; it is intentionally a separate, print-only follow-up.