Skip to content

Create get all events util and rename getEvents to getEvent#33

Open
valentinbeggi wants to merge 3 commits intoaleios-cloud:mainfrom
valentinbeggi:create-get-all-events-util
Open

Create get all events util and rename getEvents to getEvent#33
valentinbeggi wants to merge 3 commits intoaleios-cloud:mainfrom
valentinbeggi:create-get-all-events-util

Conversation

@valentinbeggi
Copy link
Contributor

fixes #15

@valentinbeggi valentinbeggi force-pushed the create-get-all-events-util branch 2 times, most recently from d05a205 to e0f57bc Compare February 4, 2022 15:24
@valentinbeggi valentinbeggi changed the title Create get all events util Create get all events util and rename getEvents to getEvent Feb 4, 2022
@valentinbeggi valentinbeggi force-pushed the create-get-all-events-util branch from e0f57bc to 2a77913 Compare February 4, 2022 15:25
Copy link

@smbkr smbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some review comments - let me know your thoughts.

I also wonder if the addition of yargs should be split into a separate PR since it's not really required for the main feature here? Edit: looks like it's already in #29 too

@valentinbeggi valentinbeggi force-pushed the create-get-all-events-util branch from 2a77913 to 0d5ed2a Compare April 1, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getEvents method name unclear

2 participants