Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive Spanish language support to the decasify library, implementing titlecasing according to Real Academia Española (RAE) guidelines.
Key changes:
- Adds new Spanish language module with RAE-compliant titlecasing rules
- Implements lowercase, uppercase, and sentence case transformations for Spanish text
- Integrates Spanish locale and RAE style guide into the type system
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/es.rs | New Spanish language module implementing titlecase (RAE style), lowercase, uppercase, and sentencecase functions with Spanish-specific reserved words |
| src/lib.rs | Routes Spanish locale to new es module functions for all case transformations |
| src/types.rs | Adds ES locale variant, RealAcademiaEspanola style guide, and parsing support for Spanish locale identifiers (with/without accents) |
| tests/lib.rs | Comprehensive test coverage for Spanish transformations including trivia handling, article/preposition rules, and all case conversions |
| README.md | Documents Spanish support and RAE styling conventions with usage caveats |
| Makefile.am | Includes es.rs in build sources |
| plugin/decasify.vim | Adds 'es' to locale completions |
| plugin/decasify.lua | Adds 'es' to locale completions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alerque
marked this pull request as ready for review
November 19, 2025 21:08
Co-authored-by: Adrián Berges <adberenf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46, needs review from native speaker(s), see issue discussion.