Skip to content

Implement support for Spanish - #50

Merged
alerque merged 6 commits into
masterfrom
spanish
Nov 20, 2025
Merged

Implement support for Spanish#50
alerque merged 6 commits into
masterfrom
spanish

Conversation

@alerque

@alerque alerque commented Nov 19, 2025

Copy link
Copy Markdown
Owner

Closes #46, needs review from native speaker(s), see issue discussion.

@alerque alerque added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 19, 2025
@alerque
alerque requested a review from Copilot November 19, 2025 20:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive Spanish language support to the decasify library, implementing titlecasing according to Real Academia Española (RAE) guidelines.

Key changes:

  • Adds new Spanish language module with RAE-compliant titlecasing rules
  • Implements lowercase, uppercase, and sentence case transformations for Spanish text
  • Integrates Spanish locale and RAE style guide into the type system

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/es.rs New Spanish language module implementing titlecase (RAE style), lowercase, uppercase, and sentencecase functions with Spanish-specific reserved words
src/lib.rs Routes Spanish locale to new es module functions for all case transformations
src/types.rs Adds ES locale variant, RealAcademiaEspanola style guide, and parsing support for Spanish locale identifiers (with/without accents)
tests/lib.rs Comprehensive test coverage for Spanish transformations including trivia handling, article/preposition rules, and all case conversions
README.md Documents Spanish support and RAE styling conventions with usage caveats
Makefile.am Includes es.rs in build sources
plugin/decasify.vim Adds 'es' to locale completions
plugin/decasify.lua Adds 'es' to locale completions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/types.rs Outdated
Comment thread src/es.rs Outdated
Comment thread tests/lib.rs Outdated
Comment thread README.md Outdated
@alerque
alerque marked this pull request as ready for review November 19, 2025 21:08
@alerque
alerque merged commit b78aee1 into master Nov 20, 2025
26 of 27 checks passed
@alerque
alerque deleted the spanish branch November 20, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spanish not implemented; panic when calling sentencecase (also others): wasm unreachable instruction executed

2 participants