fix: allow source folder copy task to dereference symlinks#424
Open
benmarch wants to merge 5 commits intoalexa:developfrom
Open
fix: allow source folder copy task to dereference symlinks#424benmarch wants to merge 5 commits intoalexa:developfrom
benmarch wants to merge 5 commits intoalexa:developfrom
Conversation
Contributor
|
Hi @benmarch, thanks for the PR |
# Conflicts: # lib/builtins/build-flows/nodejs-npm.js
Author
|
@Shreyas-vgr apologies for the delay. I've added two config options: After these changes, I realized that I could use a custom hook to accomplish the same thing, but I think there's something lost by using a hook instead of the built-in support for Node skills. Let me know what you think, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
I have my skill source code set up as a package in a monorepo, and the symlinked NPM modules (the other packages) are not copied into the build folder. This change instructs fs-extra to also copy the symlinked modules.
I wasn't sure if it was worth writing new tests for this change or updating the existing ones. I could also make this a config option for CodeBuilder instead of hardcoding it to true (and adding a cli option to set it). Any input or advice would be appreciated.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.