LibMCCore/ScanlabSMC/Scanlab: add raw simulation export and fix RTC microvector/recording timing#58
Merged
Conversation
…icrovector/recording timing ### feat(scanlabsmc): expose raw simulation data from SMC jobs - Added `LoadRawSimulationData` API to SMCJob (ACT, ABI, dynamic bindings, wrappers). - Implemented raw binary export from the SMC simulation working file and introduced `SIMULATIONWORKINGFILEISNOTINITIALIZED` error for missing simulation context. - Updated simulation-mode job startup to create a managed temp file and start module recording via `slsc_job_begin_module`. - Added SDK support for `slsc_cfg_register_callback_job_calculated` and `slsc_job_begin_module` with journal logging. ### fix(scanlab): correct microvector laser on/off delay conversion - Converted microvector laser delays from seconds to RTC ticks (100 kHz) when calling `n_micro_vector_abs`, keeping `-1` as "no delay" sentinel. ### fix(scanlab): improve RTC recording loop progress condition - Adjusted `executeListWithRecording` to use the card busy state for data-block reads and termination instead of measurement busy status to avoid missed blocks / early exit. These changes enable retrieving raw SMC simulation artifacts for downstream processing, while improving RTC replay correctness and recording reliability. Signed-off-by: Yury Rodzikau <y.rodzikau@c1-technologies.com>
alexanderoster
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LibMCCore/ScanlabSMC/Scanlab: add raw simulation export and fix RTC microvector/recording timing
feat(scanlabsmc): expose raw simulation data from SMC jobs
LoadRawSimulationDataAPI to SMCJob (ACT, ABI, dynamic bindings, wrappers).SIMULATIONWORKINGFILEISNOTINITIALIZEDerror for missing simulation context.slsc_job_begin_module.slsc_cfg_register_callback_job_calculatedandslsc_job_begin_modulewith journal logging.fix(scanlab): correct microvector laser on/off delay conversion
n_micro_vector_abs, keeping-1as "no delay" sentinel.fix(scanlab): improve RTC recording loop progress condition
executeListWithRecordingto use the card busy state for data-block reads and termination instead of measurement busy status to avoid missed blocks / early exit.