fix: gate self-upgrade for package-managed installs#27
Merged
Conversation
|
✅ All checks passed (Go 1.26) Coverage: 68.4% |
There was a problem hiding this comment.
Pull request overview
This PR gates gitm upgrade based on install channel so package-managed installs (Homebrew/Scoop) are directed to their package manager update flow, while keeping self-upgrade available for manual installs.
Changes:
- Add install-channel detection from executable path and block self-upgrade with actionable messages.
- Hide the
upgradecommand from help output for package-managed installs. - Add tests for detection/hide/block behavior and update README upgrade documentation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
internal/cli/upgrade.go |
Adds install-channel detection, command hiding, and blocked-run messaging for upgrade. |
internal/cli/upgrade_test.go |
Adds unit tests covering channel detection, hide behavior, and blocked-run errors. |
README.md |
Updates upgrade docs to distinguish manual installs vs package-managed installs. |
|
✅ All checks passed (Go 1.26) Coverage: 68.4% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gitm upgradewith actionable guidance (brew upgrade --cask gitm/scoop update gitm)upgradefor package-managed installs while preserving manual macOS/Linux behaviorValidation
rtk go test ./internal/cli -v -race -timeout 60srtk make testrtk make lint