fix dynamicconfig parsing of long integers - #988
Open
imilchev wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ivan Milchev <ivan@mondoo.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
DynamicConfigToYamlDynamicConfigdecoded CRD values viajson.Unmarshalinto anany, which always coerces JSON numbers tofloat64. A large integer like2097152becamefloat64(2097152), and yaml.v3 then marshaled it in scientific notation (2.097152e+06). Temporal's file-based dynamic config client fails to parse this for settings that expect an integer.Fix
2097152→value: 2097152).intinstead offloat64for integer values.Note
This changes integer dynamic config values from
float64tointinYamlConstrainedValue.Value. Existing config maps holding values in scientific notation get rewritten once to the clean integer form on upgrade.Fixes #517