Skip to content

Fixes#207

Merged
alexdalitz merged 6 commits into
masterfrom
fixes
Sep 4, 2025
Merged

Fixes#207
alexdalitz merged 6 commits into
masterfrom
fixes

Conversation

@alexdalitz

Copy link
Copy Markdown
Owner

Timeout::Error, untainted, and Ruby > 2.7.0

@alexdalitz

Copy link
Copy Markdown
Owner Author

@keithrbennett Could you please review this PR for me?

Comment thread lib/dnsruby.rb Outdated
Comment thread lib/dnsruby/config.rb Outdated

@keithrbennett keithrbennett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review finished. Thanks!

@alexdalitz

Copy link
Copy Markdown
Owner Author

Thanks @keithrbennett!
Once you're happy with this and approve it, I'll merge it in.
I'm hoping to release a dnsruby-1.73.0 later this week with all these changes in it.

@keithrbennett

keithrbennett commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Hi, Alex. I just realized that the version of Ruby that ships with macOS is 2.6! So if anyone is actually using that old a version using the system Ruby, then they will be unable to use dnsruby without changing their setup (using rvm or another version manager). Do we care? It's highly unlikely that anyone with any kind of important application is still using such an old version.

@keithrbennett

Copy link
Copy Markdown
Contributor

If we stay with the Ruby version >= 2.8 requirement, the code changes look good to me.

@alexdalitz

Copy link
Copy Markdown
Owner Author

Thanks @keithrbennett !

I've moved the Ruby requirement from 2.7 to 2.8 - if you're worried about 2.6, then it's been a long time since we supported that...

@alexdalitz alexdalitz merged commit ffa3269 into master Sep 4, 2025
14 of 16 checks passed
@alexdalitz alexdalitz deleted the fixes branch September 4, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants