Patch rustplus.proto

[jamezrin]

No description provided.

[alexemanuelol]

That's a clever way to do it! How did you decide which ones to set as optional? Did you go through the server dll's/ companion app?

[JulianMa]

i'm still convinced, that FP migrated from proto2 to proto3, setting them all to optional can lead to wrong data.
See my PR in liams repo for reasoning: liamcottle/rustplus.js#77
In theory, you could also reference a specific commit inside the package.json:
If liam decides not to merge, its also an option to use an unmerged PR as dependency source (commit reference from my PR in this case, but you can just fork it yourself to get more control):

{
    "name": "rustplusplus",
    "version": "1.20.0",
    "description": "A NodeJS Discord Bot that uses the rustplus.js library to utilize the power of the Rust+ Companion App with additional Quality-of-Life features.",
    "main": "index.ts",
    "scripts": {
        "start": "ts-node .",
        "preinstall": "npx npm-force-resolutions",
        "test": "tsc --noEmit -p ."
    },
    "repository": {
        "type": "git",
        "url": "https://github.com/alexemanuelol/rustplusplus.git"
    },
    "author": "Alexemanuelol",
    "license": "SEE LICENSE IN LICENSE",
    "bugs": {
        "url": "https://github.com/alexemanuelol/rustplusplus/issues"
    },
    "homepage": "https://github.com/alexemanuelol/rustplusplus#readme",
    "dependencies": {
        "@discordjs/rest": "^1.6.0",
        "@discordjs/voice": "^0.16.0",
        "@formatjs/intl": "^2.6.9",
        "@liamcottle/push-receiver": "^0.0.4",
        "@liamcottle/rustplus.js": "git://github.com/JulianMa/rustplus.js.git#9f87ea17f3d330c23615757130855590ad84ac22",
        "axios": "^1.3.4",
        "colors": "^1.4.0",
        "discord-api-types": "^0.37.37",
        "discord.js": "^14.8.0",
        "ffmpeg-static": "^5.1.0",
        "gm": "^1.25.0",
        "jimp": "^0.22.7",
        "libsodium-wrappers": "^0.7.11",
        "lodash": "^4.17.21",
        "translate": "^1.4.1",
        "ts-node": "^10.9.1",
        "typescript": "^4.8.2",
        "winston": "^3.8.2"
    },
    "resolutions": {
        "jpeg-js": "0.4.4",
        "protobufjs": "7.2.4"
    }
}

[jamezrin]

That's a clever way to do it! How did you decide which ones to set as optional? Did you go through the server dll's/ companion app?

Hey, no, I used the proto file that was mentioned in the discord announcement.

[alexemanuelol]

Temporarily fixed in 5b0c77b