Skip to content

fix(compaction): handle immutable session history #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexk-dev merged 1 commit into from
Mar 18, 2026
Merged

fix(compaction): handle immutable session history #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/main/java/me/golemcore/bot/domain/service/CompactionOrchestrationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public CompactionResult compact(String sessionId, CompactionReason reason, int k
}

AgentSession session = sessionOptional.get();
List<Message> sessionMessages = session.getMessages() != null ? session.getMessages() : new ArrayList<>();
List<Message> sessionMessages = session.getMessages() != null ? session.getMessages() : List.of();

CompactionPreparation preparation = preparationService.prepare(
sessionId,
Expand Down Expand Up @@ -99,11 +99,12 @@ public CompactionResult compact(String sessionId, CompactionReason reason, int k
}

List<Message> keptMessages = Message.flattenToolMessages(new ArrayList<>(preparation.messagesToKeep()));
sessionMessages.clear();
List<Message> mutableSessionMessages = session.mutableMessages();
mutableSessionMessages.clear();
if (summaryMessage != null) {
sessionMessages.add(summaryMessage);
mutableSessionMessages.add(summaryMessage);
}
sessionMessages.addAll(keptMessages);
mutableSessionMessages.addAll(keptMessages);

long durationMs = Math.max(0, clock.millis() - startedAt);
CompactionDetails details = detailsExtractor.extract(
Expand Down
76 changes: 76 additions & 0 deletions src/test/java/me/golemcore/bot/domain/service/CompactionOrchestrationServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,82 @@
assertEquals("s2", sessionCaptor.getValue().getId());
}

@Test
void shouldCompactWhenSessionHistoryListIsImmutable() {
Message m1 = user("u1");
Message m2 = assistant("a1");
Message m3 = user("u2");
AgentSession session = AgentSession.builder()
.id("s-immutable")
.messages(List.of(m1, m2, m3))
.metadata(new LinkedHashMap<>())
.build();
when(sessionPort.get("s-immutable")).thenReturn(Optional.of(session));

when(runtimeConfigService.isCompactionPreserveTurnBoundariesEnabled()).thenReturn(true);
when(runtimeConfigService.getCompactionDetailsMaxItemsPerCategory()).thenReturn(10);
when(runtimeConfigService.isCompactionDetailsEnabled()).thenReturn(false);

CompactionPreparation preparation = CompactionPreparation.builder()
.sessionId("s-immutable")
.reason(CompactionReason.MANUAL_COMMAND)
.messagesToCompact(List.of(m1))
.messagesToKeep(List.of(m2, m3))
.splitTurnDetected(false)
.build();
when(preparationService.prepare("s-immutable", session.getMessages(), 2, CompactionReason.MANUAL_COMMAND, true))
.thenReturn(preparation);

when(compactionService.summarize(List.of(m1))).thenReturn("sum");
Message summaryMessage = Message.builder()
.role("system")
.content("[Conversation summary]\nsum")
.metadata(new LinkedHashMap<>())
.build();
when(compactionService.createSummaryMessage("sum")).thenReturn(summaryMessage);

CompactionDetails details = CompactionDetails.builder()
.schemaVersion(1)
.reason(CompactionReason.MANUAL_COMMAND)
.summarizedCount(1)
.keptCount(2)
.usedLlmSummary(true)
.summaryLength(3)
.toolCount(0)
.readFilesCount(0)
.modifiedFilesCount(0)
.durationMs(0)
.toolNames(List.of())
.readFiles(List.of())
.modifiedFiles(List.of())
.fileChanges(List.of())
.splitTurnDetected(false)
.fallbackUsed(false)
.build();
when(detailsExtractor.extract(
eq(CompactionReason.MANUAL_COMMAND),

Check warning on line 293 in src/test/java/me/golemcore/bot/domain/service/CompactionOrchestrationServiceTest.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 


See more on https://sonarcloud.io/project/issues?id=alexk-dev_golemcore-bot&issues=AZ0B-G8k9xZfPpEov_aa&open=AZ0B-G8k9xZfPpEov_aa&pullRequest=192
eq(List.of(m1)),
eq(1),
eq(2),
eq(true),
eq(3),
eq(false),
eq(false),
eq(0L),
eq(10)))
.thenReturn(details);

CompactionResult result = service.compact("s-immutable", CompactionReason.MANUAL_COMMAND, 2);

assertEquals(1, result.removed());
assertTrue(result.usedSummary());
assertEquals(3, session.getMessages().size());
assertEquals("system", session.getMessages().getFirst().getRole());
assertEquals("assistant", session.getMessages().get(1).getRole());
assertEquals("user", session.getMessages().get(2).getRole());
verify(sessionPort).save(session);
}

@Test
void shouldFallbackWhenSummaryBlankAndSkipSummaryMetadata() {
Message m1 = user("u1");
Expand Down
Loading